-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
sysdump: Add more envoy resource types #1756
Conversation
Commit 709faa2 does not contain "Signed-off-by". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
709faa2
to
7d2209c
Compare
Commit 709faa2 does not contain "Signed-off-by". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
7d2209c
to
d0ec11e
Compare
This is to fix the issue in which CEC resources are unable to unmarshal to json due to missing registered type. Please find below one of the example failure. ``` 馃攳 Collecting the Cilium SPIRE agent daemonset 馃攳 Collecting the Cilium SPIRE agent configuration level=warning msg="Ignoring invalid CiliumEnvoyConfig JSON (proto: (line 1:405): unable to resolve \"type.googleapis.com/envoy.extensions.filters.http.router.v3.Router\": \"not found\"): {\n\t\"@type\": \"type.googleapis.com/envoy.config.listener.v3.Listener\",\n\t\"filterChains\": [\n\t\t{\n\t\t\t\"filterChainMatch\": {\n\t\t\t\t\"transportProtocol\": \"raw_buffer\"\n\t\t\t},\n\t\t\t\"filters\": [\n\t\t\t\t{\n\t\t\t\t\t\"name\": \"envoy.filters.network.http_connection_manager\",\n\t\t\t\t\t\"typedConfig\": {\n\t\t\t\t\t\t\"@type\": \"type.googleapis.com/envoy.extensions.filters.network.http_connection_manager.v3.HttpConnectionManager\",\n\t\t\t\t\t\t\"httpFilters\": [\n\t\t\t\t\t\t\t{\n\t\t\t\t\t\t\t\t\"name\": \"envoy.filters.http.router\",\n\t\t\t\t\t\t\t\t\"typedConfig\": {\n\t\t\t\t\t\t\t\t\t\"@type\": \"type.googleapis.com/envoy.extensions.filters.http.router.v3.Router\"\n\t\t\t\t\t\t\t\t}\n\t\t\t\t\t\t\t}\n\t\t\t\t\t\t],\n\t\t\t\t\t\t\"rds\": {\n\t\t\t\t\t\t\t\"routeConfigName\": \"listener-insecure\"\n\t\t\t\t\t\t},\n\t\t\t\t\t\t\"statPrefix\": \"listener-insecure\",\n\t\t\t\t\t\t\"upgradeConfigs\": [\n\t\t\t\t\t\t\t{\n\t\t\t\t\t\t\t\t\"upgradeType\": \"websocket\"\n\t\t\t\t\t\t\t}\n\t\t\t\t\t\t],\n\t\t\t\t\t\t\"useRemoteAddress\": true\n\t\t\t\t\t}\n\t\t\t\t}\n\t\t\t]\n\t\t}\n\t],\n\t\"listenerFilters\": [\n\t\t{\n\t\t\t\"name\": \"envoy.filters.listener.tls_inspector\",\n\t\t\t\"typedConfig\": {\n\t\t\t\t\"@type\": \"type.googleapis.com/envoy.extensions.filters.listener.tls_inspector.v3.TlsInspector\"\n\t\t\t}\n\t\t}\n\t],\n\t\"name\": \"listener\",\n\t\"socketOptions\": [\n\t\t{\n\t\t\t\"description\": \"Enable TCP keep-alive (default to enabled)\",\n\t\t\t\"intValue\": \"1\",\n\t\t\t\"level\": \"1\",\n\t\t\t\"name\": \"9\",\n\t\t\t\"state\": \"STATE_LISTENING\"\n\t\t},\n\t\t{\n\t\t\t\"description\": \"TCP keep-alive idle time (in seconds) (defaults to 10s)\",\n\t\t\t\"intValue\": \"10\",\n\t\t\t\"level\": \"6\",\n\t\t\t\"name\": \"4\",\n\t\t\t\"state\": \"STATE_LISTENING\"\n\t\t},\n\t\t{\n\t\t\t\"description\": \"TCP keep-alive probe intervals (in seconds) (defaults to 5s)\",\n\t\t\t\"intValue\": \"5\",\n\t\t\t\"level\": \"6\",\n\t\t\t\"name\": \"5\",\n\t\t\t\"state\": \"STATE_LISTENING\"\n\t\t},\n\t\t{\n\t\t\t\"description\": \"TCP keep-alive probe max failures.\",\n\t\t\t\"intValue\": \"10\",\n\t\t\t\"level\": \"6\",\n\t\t\t\"name\": \"6\",\n\t\t\t\"state\": \"STATE_LISTENING\"\n\t\t}\n\t]\n}" subsys=k8s-apis-cilium.io-v2 ... ``` Signed-off-by: Tam Mach <tam.mach@cilium.io>
d0ec11e
to
3ae4a0f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Vendor changes lgtm
This is to avoid any potential Relates: cilium#1756
This is to avoid the similar happening again in the future, when we add more envoy resource types. Relates: cilium#1756 Signed-off-by: Tam Mach <tam.mach@cilium.io>
This is to avoid the similar happening again in the future, when we add more envoy resource types. Relates: cilium#1756 Signed-off-by: Tam Mach <tam.mach@cilium.io>
This is to avoid the similar happening again in the future, when we add more envoy resource types. Relates: cilium#1756 Signed-off-by: Tam Mach <tam.mach@cilium.io>
This is to avoid the similar happening again in the future, when we add more envoy resource types. Relates: cilium#1756 Relates: cilium/cilium#26469 Signed-off-by: Tam Mach <tam.mach@cilium.io>
This is to avoid the similar happening again in the future, when we add more envoy resource types. Relates: cilium#1756 Relates: cilium/cilium#26469 Signed-off-by: Tam Mach <tam.mach@cilium.io>
This is to avoid the similar happening again in the future, when we add more envoy resource types. Relates: cilium#1756 Relates: cilium/cilium#26469 Signed-off-by: Tam Mach <tam.mach@cilium.io>
This is to avoid the similar happening again in the future, when we add more envoy resource types. Relates: cilium#1756 Relates: cilium/cilium#26469 Signed-off-by: Tam Mach <tam.mach@cilium.io>
This is to avoid the similar happening again in the future, when we add more envoy resource types. Relates: cilium#1756 Signed-off-by: Tam Mach <tam.mach@cilium.io>
This is to avoid the similar happening again in the future, when we add more envoy resource types. Relates: cilium#1756 Signed-off-by: Tam Mach <tam.mach@cilium.io>
This is to avoid the similar happening again in the future, when we add more envoy resource types. Relates: #1756 Signed-off-by: Tam Mach <tam.mach@cilium.io>
Description
This is to fix the issue in which CEC resources are unable to unmarshal to json due to missing registered type. Please find below one of the example failures.