clustermesh: Add support for kubernetes service annotations #1938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Commit 382c4fb does not contain "Signed-off-by". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
joaoubaldo
force-pushed
the
clustermesh_support_service_annotations
branch
from
382c4fb
to
f83f4dd
Compare
joaoubaldo
force-pushed
the
clustermesh_support_service_annotations
branch
from
f83f4dd
to
9ec75c5
Compare
derailed
approved these changes
Aug 30, 2023
|
@joaoubaldo looks like you're hitting some CI failures that were fixed last month but your branch base is out of date. Could you rebase onto latest? |
Add a `--service-annotation` argument so that custom annotations can be added to the Kubernetes Service when clustermesh is being enabled. A use case for this flag is to create a private NLB in AWS instead of a public classic LB: > cilium clustermesh enable --service-type LoadBalancer --service-annotation 'service.beta.kubernetes.io/aws-load-balancer-internal=0.0.0.0/0' --service-annotation 'service.beta.kubernetes.io/aws-load-balancer-type=nlb Signed-off-by: Joao Ubaldo <me@joaoubaldo.com>
joaoubaldo
force-pushed
the
clustermesh_support_service_annotations
branch
from
9ec75c5
to
ade7a01
Compare
|
@thorn3r rebased and all workflows that were executed passed now. Thanks |
|
@thorn3r could you please take another look? |
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a
--service-annotationargument so that custom annotations can be added to the Kubernetes Service when clustermesh is being enabled.A use case for this flag is to create a private NLB in AWS instead of a public classic LB: