sysdump: Cache Cilium pods and cilium-config ConfigMap #1992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Get Cilium pods and cilium-config ConfigMap once at the beginning to reduce the number of Kubernetes API calls. Ref: #1962 Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
michi-covalent
force-pushed
the
pr/michi/cache-it
branch
from
4d32b21
to
db644e9
Compare
derailed
requested changes
Sep 28, 2023
michi-covalent
commented
Sep 29, 2023
There was a problem hiding this comment.
hello @derailed thanks for your feedback, i replied to your comments. could you take a look again ✨🙏
derailed
approved these changes
Sep 29, 2023
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get Cilium pods and cilium-config ConfigMap once at the beginning to reduce the number of Kubernetes API calls.
Ref: #1962