refactor: Move FeatureSet to a separate package #2001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michi-covalent
requested review from
aspsk,
thorn3r,
brb,
julianwiedmann,
christarazi and
derailed
christarazi
approved these changes
Oct 2, 2023
aspsk
approved these changes
Oct 3, 2023
julianwiedmann
approved these changes
Oct 3, 2023
tklauser
reviewed
Oct 3, 2023
michi-covalent
force-pushed
the
pr/michi/quiet
branch
from
72fd54a
to
22c803f
Compare
Move FeatureSet to a separate package so that the sysdump package can import it to use the feature detection logic without introducing a circular dependency. Ref: #1962 Co-authored-by: Tobias Klauser <tobias@isovalent.com> Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
michi-covalent
force-pushed
the
pr/michi/quiet
branch
from
22c803f
to
6ebb5e0
Compare
tklauser
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move FeatureSet to a separate package so that the sysdump package can import it to use the feature detection logic without introducing a circular dependency.
Ref: #1962