Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

renovate: Don't pick up new Go patch versions in go.mod #2408

Merged
merged 2 commits into from Mar 14, 2024

Conversation

michi-covalent
Copy link
Contributor

Let's not pick up new Go patch versions in go.mod to be consistent with cilium/cilium. cilium/cilium#28686 has more context about the rationale.

This reverts commit 0e205da.

Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
@michi-covalent
Copy link
Contributor Author

cc @joestringer @tklauser just an fyi

Shamelessly copied from cilium/cilium#28686.

Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
Copy link
Member

@sayboras sayboras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, yeah, we have done the same in cilium/proxy (e.g. only 1.x but not 1.x.y)

@sayboras sayboras merged commit 2effe31 into main Mar 14, 2024
13 checks passed
@sayboras sayboras deleted the pr/michi/no-go-patch branch March 14, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants