.github: create clusters with taints #400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aanm
added
the
dont-merge/waiting-for-upstream
joestringer
approved these changes
Jul 6, 2021
nbusseneau
reviewed
Jul 8, 2021
nbusseneau
reviewed
Jul 8, 2021
nebril
approved these changes
Jul 12, 2021
twpayne
approved these changes
Jul 15, 2021
aanm
removed
the
dont-merge/waiting-for-upstream
As recommended to users, cilium-cli should also set the clusters with taints. This guarantees that Cilium is properly configured and application pods can start successfully. Signed-off-by: André Martins <andre@cilium.io>
tklauser
approved these changes
Jul 16, 2021
maintainer-s-little-helper
bot
added
the
ready-to-merge
nbusseneau
added a commit
that referenced
this pull request
Jul 19, 2021
Following merge of #400, we broke #391. This PR fixes the issue by refactoring both EKS workflows to be consistent with other workflows, now that we are creating a cluster with nodes available right away just like on other platforms, and thus do not need to split the `install`/`test` steps anymore. Fixes 3d2fbdb Signed-off-by: Nicolas Busseneau <nicolas@isovalent.com>
This was referenced Jul 19, 2021
nbusseneau
added a commit
that referenced
this pull request
Jul 19, 2021
Following merge of #400, we broke #391. This PR fixes the issue by refactoring both EKS workflows to be consistent with other workflows, now that we are creating a cluster with nodes available right away just like on other platforms, and thus do not need to split the `install`/`test` steps anymore. Fixes 3d2fbdb Signed-off-by: Nicolas Busseneau <nicolas@isovalent.com>
nbusseneau
added a commit
that referenced
this pull request
Jul 19, 2021
Following merge of #400, we broke #391. This PR fixes the issue by refactoring both EKS workflows to be consistent with other workflows, now that we are creating a cluster with nodes available right away just like on other platforms, and thus do not need to split the `install`/`test` steps anymore. Fixes 3d2fbdb Signed-off-by: Nicolas Busseneau <nicolas@isovalent.com>
michi-covalent
pushed a commit
that referenced
this pull request
Jul 19, 2021
Following merge of #400, we broke #391. This PR fixes the issue by refactoring both EKS workflows to be consistent with other workflows, now that we are creating a cluster with nodes available right away just like on other platforms, and thus do not need to split the `install`/`test` steps anymore. Fixes 3d2fbdb Signed-off-by: Nicolas Busseneau <nicolas@isovalent.com>
nbusseneau
added a commit
that referenced
this pull request
Jul 21, 2021
Following merge of #400, we broke #391. This PR fixes the issue by refactoring both EKS workflows to be consistent with other workflows, now that we are creating a cluster with nodes available right away just like on other platforms, and thus do not need to split the `install`/`test` steps anymore. Fixes 3d2fbdb Signed-off-by: Nicolas Busseneau <nicolas@isovalent.com>
aditighag
pushed a commit
to aditighag/cilium-cli
that referenced
this pull request
Apr 21, 2023
Following merge of cilium#400, we broke cilium#391. This PR fixes the issue by refactoring both EKS workflows to be consistent with other workflows, now that we are creating a cluster with nodes available right away just like on other platforms, and thus do not need to split the `install`/`test` steps anymore. Fixes 3d2fbdb Signed-off-by: Nicolas Busseneau <nicolas@isovalent.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As recommended to users, cilium-cli should also set the clusters with
taints. This guarantees that Cilium is properly configured and
application pods can start successfully.
Signed-off-by: André Martins andre@cilium.io