install: Add a hidden --base-version flag #418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michi-covalent
force-pushed
the
pr/michi/baseversion
branch
from
2c57c77
to
5677f00
Compare
tklauser
reviewed
Jul 13, 2021
michi-covalent
force-pushed
the
pr/michi/baseversion
branch
from
5677f00
to
e6ffce8
Compare
maintainer-s-little-helper
bot
assigned errordeveloper and rolinh and unassigned rolinh
tklauser
approved these changes
Jul 14, 2021
rolinh
reviewed
Jul 14, 2021
The --version flag doesn't always maps to a Cilium version. For example, Cilium CI jobs use commit SHAs as image tags. This flag allows you to explicitly provide the "base" Cilium version being installed so that the install command can configure Cilium accordingly. Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
michi-covalent
force-pushed
the
pr/michi/baseversion
branch
from
e6ffce8
to
bbc5869
Compare
rolinh
approved these changes
Jul 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The --version flag doesn't always maps to a Cilium version. For example,
Cilium CI jobs use commit SHAs as image tags. This flag allows you to
explicitly provide the "base" Cilium version being installed so that the
install command can configure Cilium accordingly.
Signed-off-by: Michi Mutsuzaki michi@isovalent.com