Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

skip Succeeded pods #431

Merged
merged 1 commit into from
Jul 15, 2021
Merged

skip Succeeded pods #431

merged 1 commit into from
Jul 15, 2021

Conversation

xyz-li
Copy link

@xyz-li xyz-li commented Jul 14, 2021

Fixes #430

@xyz-li xyz-li requested a review from a team as a code owner July 14, 2021 06:44
@maintainer-s-little-helper
Copy link

Commit b714db7 does not contain "Signed-off-by".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@xyz-li xyz-li requested a review from ldelossa July 14, 2021 06:44
@xyz-li xyz-li temporarily deployed to ci July 14, 2021 06:44 Inactive
skip Succeeded pods
045da10 
Signed-off-by: LiHui <andrewli@yunify.com>
@xyz-li xyz-li temporarily deployed to ci July 14, 2021 06:51 Inactive
ldelossa
ldelossa approved these changes Jul 14, 2021
View reviewed changes
Copy link
Contributor

@ldelossa ldelossa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tklauser
tklauser approved these changes Jul 15, 2021
View reviewed changes
Copy link
Member

@tklauser tklauser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@tklauser tklauser merged commit 1e37a04 into cilium:master Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tklauser tklauser tklauser approved these changes

@ldelossa ldelossa ldelossa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cilium should not delete succeeded pods
3 participants
@xyz-li @tklauser @ldelossa