workflows: add test exceptions to EKS tunnel workflow #450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbusseneau
added
the
dont-merge/preview-only
nbusseneau
force-pushed
the
pr/workflows-fix-eks-tunnel
branch
from
4b863d4
to
9f0671c
Compare
nbusseneau
force-pushed
the
pr/workflows-fix-eks-tunnel
branch
from
3bb05c0
to
f62974c
Compare
nbusseneau
force-pushed
the
pr/workflows-fix-eks-tunnel
branch
from
f62974c
to
763c6e8
Compare
nbusseneau
force-pushed
the
pr/workflows-fix-eks-tunnel
branch
from
315bde2
to
a8a38aa
Compare
nbusseneau
force-pushed
the
pr/workflows-fix-eks-tunnel
branch
from
a8a38aa
to
923ee17
Compare
Following merge of #251, testing on EKS in tunnel mode is now reliably broken due to an issue in upstream: cilium/cilium#16975 This type of failure was already happening before #251, but the PR made it very evident as before we were only running checks from a few random pods (which would sometimes work) and are now running checks from all pods, drastically increasing the chance of hitting at least one failure. Since the test setup is not to blame and this is an actual issue with Cilium in tunnel momde, we disable the failing tests until upstream issue is fixed. Signed-off-by: Nicolas Busseneau <nicolas@isovalent.com>
nbusseneau
force-pushed
the
pr/workflows-fix-eks-tunnel
branch
from
923ee17
to
7b4af33
Compare
nbusseneau
changed the title
nbusseneau
added
area/CI
|
Link to working test run of the changes in the EKS tunnel workflow: https://github.com/cilium/cilium-cli/actions/runs/1056560809 |
ti-mo
approved these changes
Jul 22, 2021
michi-covalent
approved these changes
Jul 22, 2021
christarazi
approved these changes
Jul 22, 2021
|
ok let's ship it |
|
It seems this is just happening because of leftover iptables rules from aws-node. I confirmed the full connectivity tests pass locally on EKS+overlay once the rules are removed. See cilium/cilium#26897 (comment) for details. We can probably revert this and should even support removal of those rules in the CLI IMO. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following merge of #251, testing on EKS in tunnel mode is now reliably broken due to an issue in upstream: cilium/cilium#16975
This type of failure was already happening before #251, but the PR made it very evident as before we were only running checks from a few random pods (which would sometimes work) and are now running checks from all pods, drastically increasing the chance of hitting at least one failure.
Since the test setup is not to blame and this is an actual issue with Cilium in tunnel mode, we disable the failing tests until upstream issue is fixed.