workflows: fix in-cluster job kubectl wait #451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbusseneau
force-pushed
the
pr/workflows-fix-wait
branch
from
dc04715
to
34f9c3f
Compare
nbusseneau
force-pushed
the
pr/workflows-fix-wait
branch
from
34f9c3f
to
2dd1b37
Compare
nbusseneau
force-pushed
the
pr/workflows-fix-wait
branch
from
2dd1b37
to
4597588
Compare
nbusseneau
force-pushed
the
pr/workflows-fix-wait
branch
from
4597588
to
ff82cc9
Compare
|
Links to test runs of workflow changes:
|
michi-covalent
approved these changes
Jul 21, 2021
`kubectl wait --for=condition=complete --timeout=X` behaviour is a bit counterintuitive: it waits until either the job succeeds or timeout is hit. When the job fails, it does not stop waiting: it will continue waiting until timeout is hit. For watching for failures, `--for=condition=failed` should be used. However, this will likewise wait until either the job fails or timeout is hit, and will not stop waiting if the job succeeds. `kubectl wait` unfortunately does not allow waiting for multiple conditions. To work around this, we set up two concurrent background waits for both conditions, and actively wait for the first one to end. This will ensure we do not wait for the whole allocated timeout everytime there is an error during the in-cluster script execution. Signed-off-by: Nicolas Busseneau <nicolas@isovalent.com>
|
All test runs passed except EKS (tunnel), but that is because of the consistent failure discussed on Slack here. Since:
=> We are in one of the exception cases to the zero-flakes strategy and do not need to wait to rebase on top of the future (hopefully soon) fix for the EKS (tunnel) workflow. This PR can be marked as |
nbusseneau
force-pushed
the
pr/workflows-fix-wait
branch
from
ff82cc9
to
3ef26b8
Compare
aanm
requested changes
Jul 22, 2021
Sir, this is |
aanm
approved these changes
Jul 22, 2021
nbusseneau
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kubectl wait --for=condition=complete --timeout=Xbehaviour is a bit counterintuitive: it waits until either the job succeeds or timeout is hit. When the job fails, it does not stop waiting: it will continue waiting until timeout is hit.For watching for failures,
--for=condition=failedshould be used. However, this will likewise wait until either the job fails or timeout is hit, and will not stop waiting if the job succeeds.kubectl waitunfortunately does not allow waiting for multiple conditions. To work around this, we set up two concurrent background waits for both conditions, and actively wait for the first one to end.This will ensure we do not wait for the whole allocated timeout everytime there is an error during the in-cluster script execution.