sysdump: Collect hubble flows #458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michi-covalent
force-pushed
the
pr/michi/sysdump-flows
branch
from
39ec022
to
2452254
Compare
|
test failures are not releated to the PR, but looking into it... |
michi-covalent
force-pushed
the
pr/michi/sysdump-flows
branch
from
2452254
to
08a38a8
Compare
|
🤟 |
ldelossa
approved these changes
Jul 30, 2021
|
marking as draft 😞 |
michi-covalent
force-pushed
the
pr/michi/sysdump-flows
branch
from
08a38a8
to
80af21a
Compare
|
working around cilium/cilium#17036 for now by running |
gandro
reviewed
Aug 3, 2021
nbusseneau
approved these changes
Aug 3, 2021
michi-covalent
force-pushed
the
pr/michi/sysdump-flows
branch
from
f8d1e02
to
18af86a
Compare
michi-covalent
force-pushed
the
pr/michi/sysdump-flows
branch
from
18af86a
to
0f496a6
Compare
|
attempting to fix the external workloads failure in #463 |
Optionally collect hubble flows as a part of sysdump. This PR adds two
new flags to the sysdump subcommand:
--hubble-flows-timeout
Timeout for the flow collection task. Default to 5 seconds.
--hubble-flows-count
Specifies the --last flag to pass to hubble observe command. Default
to zero, which disables the flow collection altogether. Note that the
actual number of flows that get collected might be different from the
value specified by this flag.
The output file can then be passed to hubble observe command, for example:
cat hubble-flows-cilium-nq247-20210729-220228.json | hubble observe
Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
Set --hubble-flows-count in the Kind workflow to test the flow collection logic. I'll update other workflows once this PR gets merged. Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
michi-covalent
force-pushed
the
pr/michi/sysdump-flows
branch
from
0f496a6
to
01f8d41
Compare
|
rebased to pick up #463 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optionally collect hubble flows as a part of sysdump. This PR adds two
new flags to the sysdump subcommand:
--hubble-flows-timeout
Timeout for the flow collection task. Default to 5 seconds.
--hubble-flows-count
Specifies the --last flag to pass to hubble observe command. Default
to zero, which disables the flow collection altogether. Note that the
actual number of flows that get collected might be different from the
value specified by this flag.
The output file can then be passed to hubble observe command, for example:
Signed-off-by: Michi Mutsuzaki michi@isovalent.com