Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transform flags context and namespace to be global for cilium-cli #792

Conversation

tvonhacht
Copy link

@tvonhacht tvonhacht commented Apr 13, 2022

I would like the cilium-cli to not fail if --context or --namespace are provided to high level commands like in kubectl. We use this very heavily to add this via a little function and read from Environment variables to use tools like kubectl stern etc easily inside a terminal without needing to provide --context and --namespace specifically every time, or even run commands in different environments with different context.

Signed-off-by: Thorben von Hacht thorbenvh8@gmail.com

@maintainer-s-little-helper
Copy link

Commit 2542df9 does not contain "Signed-off-by".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

I would like the cilium-cli to not fail if --context or --namespace are provided to high level commands like in kubectl. We use this very heavily to add this via a little function and read from Environment variables to use tools like kubectl stern etc easily inside a terminal without needing to provide --context and --namespace specifically every time, or even run commands in different environments with different context.

Signed-off-by: Thorben von Hacht <thorbenvh8@gmail.com>
@tvonhacht tvonhacht force-pushed the feature/cli-context-namespace-persistent-flag branch from ee58966 to 668838a Compare April 13, 2022 20:06
@tvonhacht tvonhacht temporarily deployed to ci April 13, 2022 20:07 Inactive
Copy link
Contributor

@twpayne twpayne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Apr 19, 2022
@tklauser tklauser merged commit 5c116aa into cilium:master Apr 19, 2022
@tvonhacht tvonhacht deleted the feature/cli-context-namespace-persistent-flag branch April 19, 2022 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants