install: Add Peer Service on Install #809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the Peer Service file is present it should be installed. Signed-off-by: Nate Sweet <nathanjsweet@pm.me>
| switch { | ||
| case versioncheck.MustCompile(">1.11.0")(ciliumVer): | ||
| svcFilename = "templates/cilium-agent/peer-service.yaml" | ||
| case versioncheck.MustCompile(">1.9.0")(ciliumVer): |
There was a problem hiding this comment.
why do we need this for v1.10? isn't this only for v1.12 or later?
There was a problem hiding this comment.
No, we are backporting the peer service. The function will still work (just return a nil service) even if the file is not present or empty).
There was a problem hiding this comment.
@nathanjsweet @michi-covalent this is not in the right place, it should be in the installer of hubble-relay here. This also needs to be uninstalled, so that we clean up when hubble is removed which should be done here
michi-covalent
approved these changes
Apr 25, 2022
michi-covalent
deleted the
pr/nathanjsweet/add-peer-service-to-installation
branch
maintainer-s-little-helper
bot
added
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the Peer Service file is present it should be installed.
Signed-off-by: Nate Sweet nathanjsweet@pm.me