install: Wait for test pods to be cleaned up #820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If test pods deletion takes longer than that of (cni) cilium pods, test pods are stuck in the "terminating" state. This ends up failing CI jobs in the clean-up stage. Hence, wait until test pods are deleted before moving onto the CNI related clean-up. Signed-off-by: Aditi Ghag <aditi@cilium.io>
aanm
reviewed
Apr 29, 2022
|
All tests passed. Looking at the AKS workflow runs, I don't see the clean-up related flakes - https://github.com/cilium/cilium-cli/actions/workflows/aks.yaml?page=2. So I'm not sure if we want to get more runs of the CI. This will likely fix the flakes seen on cilium/cilium repo though so better to merge the PR soon. |
pchaigno
approved these changes
Apr 29, 2022
michi-covalent
approved these changes
Apr 29, 2022
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If test pods deletion takes longer than that of (cni)
cilium pods, test pods are stuck in the "terminating"
state. This ends up failing CI jobs in the clean-up stage.
Hence, wait until test pods are deleted before moving
onto the CNI related clean-up.
Signed-off-by: Aditi Ghag aditi@cilium.io