Fix peer service deletion #824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nate Sweet <nathanjsweet@pm.me>
Certain deletion/disable steps require generating the helm output generated on install in order to determine what to delete. If a custom chart (one not listed in the official helm repository) is used to install cilium it stands to reason the same chart will be needed to uninstall cilium. Signed-off-by: Nate Sweet <nathanjsweet@pm.me>
aanm
approved these changes
Apr 29, 2022
Signed-off-by: Nate Sweet <nathanjsweet@pm.me>
michi-covalent
approved these changes
Apr 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
uninstall: Add Chart Directory Opt for Uninstall and Disable
Certain deletion/disable steps require generating the
helm output generated on install in order to determine
what to delete. If a custom chart (one not listed in the
official helm repository) is used to install cilium
it stands to reason the same chart will be needed to uninstall
cilium.
hubble: Log Deletion of Peer Service