clustermesh: Update cluster-name/cluster-id validation message #948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aanm
requested changes
Jun 24, 2022
sayboras
force-pushed
the
tam/clustermesh-error
branch
from
df340b2
to
3b68f70
Compare
This commit is to make the message clearer if default values are used. Reported by cilium user in slack channel. Suggested-by: André Martins <andre@cilium.io> Signed-off-by: Tam Mach <tam.mach@cilium.io>
sayboras
force-pushed
the
tam/clustermesh-error
branch
from
3b68f70
to
33891e3
Compare
tklauser
approved these changes
Jun 27, 2022
aanm
approved these changes
Jun 27, 2022
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit is to make the message clearer if default values are used.
Reported by cilium user in slack channel.
Suggested-by: André Martins andre@cilium.io
Signed-off-by: Tam Mach tam.mach@cilium.io