sysdump: Add kvstore data to dumps. #972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squeed
reviewed
Jul 18, 2022
| ps, err := c.Client.ListPods(ctx, c.Options.CiliumNamespace, metav1.ListOptions{ | ||
| LabelSelector: c.Options.CiliumLabelSelector, | ||
| }) | ||
| if err != nil { |
There was a problem hiding this comment.
Suggestion: loop over pods, pick one that is scheduled and (ideally) has all containers running.
squeed
reviewed
Jul 18, 2022
| prefix: "state/services", | ||
| }, | ||
| } { | ||
| stdout, stderr, err := c.Client.ExecInPodWithStderr(ctx, pod.Namespace, pod.Name, defaults.AgentContainerName, []string{ |
There was a problem hiding this comment.
I just committed a function, ensureExecTarget, which you may find useful here (albeit a bit overkill).
There was a problem hiding this comment.
Oh very nice, ill take a look at.
tommyp1ckles
force-pushed
the
pr/tommyp1ckles/include-kvstore-data-in-sysdump
branch
from
20f0599
to
2f3f01b
Compare
tommyp1ckles
force-pushed
the
pr/tommyp1ckles/include-kvstore-data-in-sysdump
branch
from
2f3f01b
to
4eb9033
Compare
When running sysdump, if kvstore is detected then various kvstore paths are added to the dump. Signed-off-by: Tom Hadlaw <tom.hadlaw@isovalent.com>
tommyp1ckles
force-pushed
the
pr/tommyp1ckles/include-kvstore-data-in-sysdump
branch
from
4eb9033
to
f37f8a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running sysdump, if kvstore is detected then various kvstore paths are added to the dump.
This is intended to be used by the debug-ability tools to help diagnose issues.
Signed-off-by: Tom Hadlaw tom.hadlaw@isovalent.com