clustermesh: Validate cluster-id value as per requirement #978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tklauser
requested changes
Jul 19, 2022
|
Commit 9bf352b does not contain "Signed-off-by". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
|
Commits 9bf352b, 8493487 do not contain "Signed-off-by". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
sayboras
force-pushed
the
tam/cluster-id-validtation
branch
from
8493487
to
a4c498e
Compare
This commit is to make sure that cluster-id is numeric and within range of 1-255. https://docs.cilium.io/en/stable/gettingstarted/clustermesh/clustermesh/#gs-clustermesh Fixes: cilium#143 Signed-off-by: Tam Mach <tam.mach@cilium.io>
tklauser
force-pushed
the
tam/cluster-id-validtation
branch
from
a4c498e
to
847e72e
Compare
tklauser
approved these changes
Jul 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit is to make sure that cluster-id is numeric and within range
of 1-255.
https://docs.cilium.io/en/stable/gettingstarted/clustermesh/clustermesh/#gs-clustermesh
Fixes: #143
Signed-off-by: Tam Mach tam.mach@cilium.io