connectivity: Add --assume-cilium-version flag #982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The connectivity tests run depend on the Cilium version detected. In some cases (e.g. when run against Isovalent Cilium Enterprise) the Cilium version is not detected correctly and the connectivity tests fall back to assuming the latest Cilium version. These tests may fail if the actual Cilium version is too old. This commit adds an --assume-cilium-version flag to cilium connectivity test to allow the version to be set explicitly, rather than falling back to the latest by default. This is useful for CI when running the connectivity tests against older versions of Cilium. Signed-off-by: Tom Payne <tom@isovalent.com>
gandro
approved these changes
Jul 19, 2022
michi-covalent
approved these changes
Jul 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The connectivity tests run depend on the Cilium version detected. In
some cases (e.g. when run against Isovalent Cilium Enterprise) the
Cilium version is not detected correctly and the connectivity tests fall
back to assuming the latest Cilium version. These tests may fail if the
actual Cilium version is too old.
This commit adds an --assume-cilium-version flag to cilium connectivity
test to allow the version to be set explicitly, rather than falling back
to the latest by default. This is useful for CI when running the
connectivity tests against older versions of Cilium.
Signed-off-by: Tom Payne tom@isovalent.com