ci: explicitly wait for cilium status after enabling Hubble relay on GKE #986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're occasionally encountering #918 on GKE too, e.g. https://github.com/cilium/cilium-cli/runs/7421447399?check_suite_focus=true Apply the same workaround as already added for EKS in commit a0faf25 ("ci: explicitly wait for cilium status after enabling Hubble relay") and for AKS in commit 7176ce5 ("ci: explicitly wait for cilium status after enabling Hubble relay on AKS"). Signed-off-by: Tobias Klauser <tobias@cilium.io>
gandro
approved these changes
Jul 20, 2022
maintainer-s-little-helper
bot
added
the
ready-to-merge
learnitall
added a commit
to learnitall/cilium
that referenced
this pull request
Jun 2, 2023
This commit adds calls to `cilium status --wait` between places where hubble is enabled and hubble-relay is port forwarded. Flakes in CI were occurring due to a race conditition, where an attempt to forward the hubble-relay port was occurring before the hubble-relay pod was ready. Related: cilium/cilium-cli#986 Fixes: cilium#25560 Signed-off-by: Ryan Drew <ryan.drew@isovalent.com>
aspsk
pushed a commit
to cilium/cilium
that referenced
this pull request
Jun 8, 2023
This commit adds calls to `cilium status --wait` between places where hubble is enabled and hubble-relay is port forwarded. Flakes in CI were occurring due to a race conditition, where an attempt to forward the hubble-relay port was occurring before the hubble-relay pod was ready. Related: cilium/cilium-cli#986 Fixes: #25560 Signed-off-by: Ryan Drew <ryan.drew@isovalent.com>
dylandreimerink
pushed a commit
to cilium/cilium
that referenced
this pull request
Jun 8, 2023
This commit adds calls to `cilium status --wait` between places where hubble is enabled and hubble-relay is port forwarded. Flakes in CI were occurring due to a race conditition, where an attempt to forward the hubble-relay port was occurring before the hubble-relay pod was ready. Related: cilium/cilium-cli#986 Fixes: #25560 Signed-off-by: Ryan Drew <ryan.drew@isovalent.com>
romanspb80
pushed a commit
to romanspb80/cilium
that referenced
this pull request
Jun 22, 2023
This commit adds calls to `cilium status --wait` between places where hubble is enabled and hubble-relay is port forwarded. Flakes in CI were occurring due to a race conditition, where an attempt to forward the hubble-relay port was occurring before the hubble-relay pod was ready. Related: cilium/cilium-cli#986 Fixes: cilium#25560 Signed-off-by: Ryan Drew <ryan.drew@isovalent.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're occasionally encountering #918 on GKE too, e.g.
https://github.com/cilium/cilium-cli/runs/7421447399?check_suite_focus=true
Apply the same workaround as already added for EKS in commit
a0faf25 ("ci: explicitly wait for cilium status after enabling
Hubble relay") and for AKS in commit 7176ce5 ("ci: explicitly wait
for cilium status after enabling Hubble relay on AKS").