connectivity: Detect version from cilium pods #987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes the version detection away from the version state stored during `cilium install`, and instead relies on the actual version reported by `cilium version` in the Cilium pods. This fixes an issue where `cilium connectivity test` could not be used if Cilium was not installed via CLI (e.g. via Helm). The version of all Cilium pods is parsed, and only the minimum version is used. This ensures that we can use the lowest common denominator in terms of features. Signed-off-by: Sebastian Wicki <sebastian@isovalent.com>
tklauser
approved these changes
Jul 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes the version detection away from the version state
stored during
cilium install, and instead relies on the actual versionreported by
cilium versionin the Cilium pods. This fixes an issuewhere
cilium connectivity testcould not be used if Cilium was notinstalled via CLI (e.g. via Helm).
The version of all Cilium pods is parsed, and only the minimum version
is used. This ensures that we can use the lowest common denominator in
terms of features.