connectivity: Add node-local-dns match labels #995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
2 tasks
tklauser
reviewed
Jul 28, 2022
There was a problem hiding this comment.
Is there a reason we don't need the matchLabels for node-local DNS in the client-egress-to-entities-world policy?
When node-local dns is deployed along with local redirect policy [1], the DNS traffic is redirected to node-local dns cache pods. Hence, allow such DNS traffic in the connectivity test policy yamls. [1] https://docs.cilium.io/en/latest/gettingstarted/local-redirect-policy/#node-local-dns-cache Signed-off-by: Aditi Ghag <aditi@cilium.io>
aditighag
force-pushed
the
pr/aditighag/connectivity-allow-node-local-dns
branch
from
821cb66
to
31452e4
Compare
Good catch, thanks! Fixed it. PTAL. |
|
The sole failure in multicluster is a flake, previous failures - https://github.com/cilium/cilium-cli/runs/7496646101?check_suite_focus=true. The PR already have a successful run - https://github.com/cilium/cilium-cli/actions/runs/2750016556. As the changes are purely in the connectivity tests, marking it as ready to merge. |
aditighag
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When node-local dns is deployed along with local
redirect policy [1], the DNS traffic is redirected
to node-local dns cache pods. Hence, allow such DNS
traffic in the connectivity test policy yamls.
[1] https://docs.cilium.io/en/latest/gettingstarted/local-redirect-policy/#node-local-dns-cache
Reported-by: Julien Boulanger julien.boulanger@fr.clara.net
Signed-off-by: Aditi Ghag aditi@cilium.io