Skip to content

Commit

Permalink
cilium/cmd: remove deprecated rev flag used with `cilium service upda…
Browse files Browse the repository at this point in the history
…te` (#12692)

* tests: remove deprecated 10-proxy.sh

This test is no longer executed since it was disabled/deprecated in
commit 599d0c6 ("tests: deprecate 10-proxy.sh"). It uses the
deprecated and non-functional `cilium service update --rev` flag which
will be removed in the successive commit, so remove the test script as
well.

Signed-off-by: Tobias Klauser <tklauser@distanz.ch>

* cilium/cmd: remove deprecated rev flag used with cilium service update

This was deprecated for 1.7 in commit 39dea00 ("cli: Warn if --rev
flag is used with cilium service update") and no longer provides any
functionality. Remove it for 1.9.

Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
  • Loading branch information
tklauser committed Jul 28, 2020
1 parent 56a9c1f commit 0a4f34a
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 345 deletions.
3 changes: 0 additions & 3 deletions cilium/cmd/service_update.go
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ import (
)

var (
deprecatedAddRev bool // TODO(v1.8+): remove it
k8sExternalIPs bool
k8sNodePort bool
k8sHostPort bool
Expand Down Expand Up @@ -58,8 +57,6 @@ func init() {
serviceUpdateCmd.Flags().BoolVarP(&k8sHostPort, "k8s-host-port", "", false, "Set service as a k8s HostPort")
serviceUpdateCmd.Flags().StringVarP(&k8sTrafficPolicy, "k8s-traffic-policy", "", "Cluster", "Set service with k8s externalTrafficPolicy as {Local,Cluster}")
serviceUpdateCmd.Flags().BoolVarP(&k8sClusterInternal, "k8s-cluster-internal", "", false, "Set service as cluster-internal for externalTrafficPolicy=Local")
serviceUpdateCmd.Flags().BoolVarP(&deprecatedAddRev, "rev", "", false, "Add reverse translation")
serviceUpdateCmd.Flags().MarkDeprecated("rev", "and it is inactive")
serviceUpdateCmd.Flags().StringVarP(&frontend, "frontend", "", "", "Frontend address")
serviceUpdateCmd.Flags().StringSliceVarP(&backends, "backends", "", []string{}, "Backend address or addresses (<IP:Port>)")
}
Expand Down
342 changes: 0 additions & 342 deletions tests/10-proxy.sh

This file was deleted.

0 comments on commit 0a4f34a

Please sign in to comment.