Skip to content

Commit

Permalink
Dockerfile: use alpine 3.12
Browse files Browse the repository at this point in the history
In Alpine 3.11 and 3.13, 'nslookup' exits with the error code 1 if it
can't resolve all IPs for the search list defined in /etc/resolv.conf

However, it seems that Alpine 3.10 and 3.12 are not affected by this bug
and continue return the error code 0 if at least on of the domains in
the search list is resolved into an IP address. Thus, we will use the
latest Alpine image available for the 3.12 release series.

Signed-off-by: André Martins <andre@cilium.io>
  • Loading branch information
aanm committed Apr 30, 2021
1 parent 69f10ed commit 0bd8de8
Show file tree
Hide file tree
Showing 20 changed files with 111 additions and 103 deletions.
4 changes: 3 additions & 1 deletion contrib/coccinelle/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
FROM docker.io/library/alpine:3.13.1@sha256:08d6ca16c60fe7490c03d10dc339d9fd8ea67c6466dea8d558526b1330a85930
# Do not upgrade to alpine 3.13 as its nslookup tool returns 1, instead of 0
# for domain name lookups.
FROM docker.io/library/alpine:3.12.7@sha256:36553b10a4947067b9fbb7d532951066293a68eae893beba1d9235f7d11a20ad

LABEL maintainer="maintainer@cilium.io"

Expand Down
2 changes: 1 addition & 1 deletion examples/kubernetes-memcached/memcd-sw-app.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ spec:
spec:
containers:
- name: starfigher
image: alpine
image: docker.io/library/alpine:3.12.7@sha256:36553b10a4947067b9fbb7d532951066293a68eae893beba1d9235f7d11a20ad
command: ["sleep"]
args: ["30000"]
---
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 0bd8de8

Please sign in to comment.