Skip to content

Commit

Permalink
bpf: nodeport: clean up stale comment
Browse files Browse the repository at this point in the history
The comment regarding a `dir` branch is from back when we had a shared
tail-call for Ingress & Egress NAT handling. Now that this has been split
in two tail-calls, the comment doesn't make any sense. Clean it up.

Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
  • Loading branch information
julianwiedmann committed Apr 5, 2023
1 parent 706edac commit 0ee2d5b
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions bpf/lib/nodeport.h
Original file line number Diff line number Diff line change
Expand Up @@ -1939,9 +1939,7 @@ int tail_nodeport_nat_egress_ipv4(struct __ctx_buff *ctx)

info = ipcache_lookup4(&IPCACHE_MAP, ip4->daddr, V4_CACHE_KEY_LEN, 0);
if (info && info->tunnel_endpoint != 0) {
/* The dir == NAT_DIR_EGRESS branch is executed for
* N/S LB requests which needs to be fwd-ed to a remote
* node. As the request came from outside, we need to
/* The request came from outside, so we need to
* set the security id in the tunnel header to WORLD_ID.
* Otherwise, the remote node will assume, that the
* request originated from a cluster node which will
Expand Down

0 comments on commit 0ee2d5b

Please sign in to comment.