Skip to content

Commit

Permalink
.github: remove comments of GH action versions
Browse files Browse the repository at this point in the history
Dependabot will update those commit SHAs automatically and the version
number will quickly outdated. To avoid confusion, we will remove the
comments related with the versions a SHA points to from all GH actions.

Signed-off-by: André Martins <andre@cilium.io>
  • Loading branch information
aanm committed Mar 8, 2021
1 parent 926fc7f commit 1273c57
Show file tree
Hide file tree
Showing 3 changed files with 24 additions and 24 deletions.
12 changes: 6 additions & 6 deletions .github/workflows/images-legacy-hotfix-releases.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,10 @@ jobs:
dockerfile: ./cilium-docker-plugin.Dockerfile
steps:
- name: Set up Docker Buildx
uses: docker/setup-buildx-action@154c24e1f33dbb5865a021c99f1318cfebf27b32 # v1.1.1
uses: docker/setup-buildx-action@154c24e1f33dbb5865a021c99f1318cfebf27b32

- name: Login to quay.io
uses: docker/login-action@f3364599c6aa293cdc2b8391b1b56d0c30e45c8a # v1.8.0
uses: docker/login-action@f3364599c6aa293cdc2b8391b1b56d0c30e45c8a
with:
registry: quay.io
username: ${{ secrets.QUAY_DEVELOPER_USERNAME }}
Expand All @@ -55,10 +55,10 @@ jobs:
fi
- name: Checkout Source Code
uses: actions/checkout@5a4ac9002d0be2fb38bd78e4b4dbde5606d7042f # v2.3.4
uses: actions/checkout@5a4ac9002d0be2fb38bd78e4b4dbde5606d7042f

- name: Release Build ${{ matrix.name }}
uses: docker/build-push-action@9379083e426e2e84abb80c8c091f5cdeb7d3fd7a # v2.2.2
uses: docker/build-push-action@9379083e426e2e84abb80c8c091f5cdeb7d3fd7a
id: docker_build_release
with:
context: .
Expand All @@ -80,7 +80,7 @@ jobs:
# Upload artifact digests
- name: Upload artifact digests
uses: actions/upload-artifact@e448a9b857ee2131e752b06002bf0e093c65e571 # v2
uses: actions/upload-artifact@e448a9b857ee2131e752b06002bf0e093c65e571
with:
name: image-digest ${{ matrix.name }}
path: image-digest
Expand All @@ -98,7 +98,7 @@ jobs:
mkdir -p image-digest/
- name: Download digests of all images built
uses: actions/download-artifact@4a7a711286f30c025902c28b541c10e147a9b843 # v2.0.8
uses: actions/download-artifact@4a7a711286f30c025902c28b541c10e147a9b843
with:
path: image-digest/

Expand Down
18 changes: 9 additions & 9 deletions .github/workflows/images-legacy-releases.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -40,16 +40,16 @@ jobs:

steps:
- name: Set up Docker Buildx
uses: docker/setup-buildx-action@154c24e1f33dbb5865a021c99f1318cfebf27b32 # v1.1.1
uses: docker/setup-buildx-action@154c24e1f33dbb5865a021c99f1318cfebf27b32

- name: Login to DockerHub
uses: docker/login-action@f3364599c6aa293cdc2b8391b1b56d0c30e45c8a # v1.8.0
uses: docker/login-action@f3364599c6aa293cdc2b8391b1b56d0c30e45c8a
with:
username: ${{ secrets.DOCKER_HUB_RELEASE_USERNAME }}
password: ${{ secrets.DOCKER_HUB_RELEASE_PASSWORD }}

- name: Login to quay.io
uses: docker/login-action@f3364599c6aa293cdc2b8391b1b56d0c30e45c8a # v1.8.0
uses: docker/login-action@f3364599c6aa293cdc2b8391b1b56d0c30e45c8a
with:
registry: quay.io
username: ${{ secrets.QUAY_USERNAME_RELEASE_USERNAME }}
Expand All @@ -61,10 +61,10 @@ jobs:
echo ::set-output name=tag::${GITHUB_REF##*/}
- name: Checkout Source Code
uses: actions/checkout@5a4ac9002d0be2fb38bd78e4b4dbde5606d7042f # v2.3.4
uses: actions/checkout@5a4ac9002d0be2fb38bd78e4b4dbde5606d7042f

- name: Release Build ${{ matrix.name }}
uses: docker/build-push-action@9379083e426e2e84abb80c8c091f5cdeb7d3fd7a # v2.2.2
uses: docker/build-push-action@9379083e426e2e84abb80c8c091f5cdeb7d3fd7a
id: docker_build_release
with:
context: .
Expand Down Expand Up @@ -96,7 +96,7 @@ jobs:
# Upload artifact digests
- name: Upload artifact digests
uses: actions/upload-artifact@e448a9b857ee2131e752b06002bf0e093c65e571 # v2
uses: actions/upload-artifact@e448a9b857ee2131e752b06002bf0e093c65e571
with:
name: image-digest ${{ matrix.name }}
path: image-digest
Expand All @@ -119,7 +119,7 @@ jobs:
mkdir -p image-digest/
- name: Download digests of all images built
uses: actions/download-artifact@4a7a711286f30c025902c28b541c10e147a9b843 # v2.0.8
uses: actions/download-artifact@4a7a711286f30c025902c28b541c10e147a9b843
with:
path: image-digest/

Expand All @@ -141,15 +141,15 @@ jobs:
# Upload artifact digests
- name: Upload artifact digests
uses: actions/upload-artifact@e448a9b857ee2131e752b06002bf0e093c65e571 # v2
uses: actions/upload-artifact@e448a9b857ee2131e752b06002bf0e093c65e571
with:
name: image-digest-output.txt-${{ steps.tag.outputs.tag }}
path: image-digest-output.txt
retention-days: 1

# Upload artifact digests
- name: Upload artifact digests
uses: actions/upload-artifact@e448a9b857ee2131e752b06002bf0e093c65e571 # v2
uses: actions/upload-artifact@e448a9b857ee2131e752b06002bf0e093c65e571
with:
name: Makefile.digests-${{ steps.tag.outputs.tag }}
path: Makefile.digests
Expand Down
18 changes: 9 additions & 9 deletions .github/workflows/images-legacy.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -35,14 +35,14 @@ jobs:
dockerfile: ./cilium-docker-plugin.Dockerfile
steps:
- name: Set up Docker Buildx
uses: docker/setup-buildx-action@154c24e1f33dbb5865a021c99f1318cfebf27b32 # v1.1.1
uses: docker/setup-buildx-action@154c24e1f33dbb5865a021c99f1318cfebf27b32
- name: Login to DockerHub to avoid rate limit
uses: docker/login-action@f3364599c6aa293cdc2b8391b1b56d0c30e45c8a # v1.8.0
uses: docker/login-action@f3364599c6aa293cdc2b8391b1b56d0c30e45c8a
with:
username: ${{ secrets.DOCKER_HUB_USERNAME_CI }}
password: ${{ secrets.DOCKER_HUB_PASSWORD_CI }}
- name: Login to quay.io for CI
uses: docker/login-action@f3364599c6aa293cdc2b8391b1b56d0c30e45c8a # v1.8.0
uses: docker/login-action@f3364599c6aa293cdc2b8391b1b56d0c30e45c8a
with:
registry: quay.io
username: ${{ secrets.QUAY_USERNAME_CI }}
Expand All @@ -51,10 +51,10 @@ jobs:
# v1.9 branch pushes
- name: Checkout v1.9 Branch Source Code
if: ${{ github.event_name != 'pull_request_target' }}
uses: actions/checkout@5a4ac9002d0be2fb38bd78e4b4dbde5606d7042f # v2.3.4
uses: actions/checkout@5a4ac9002d0be2fb38bd78e4b4dbde5606d7042f
- name: CI Build ${{ matrix.name }}
if: ${{ github.event_name != 'pull_request_target' }}
uses: docker/build-push-action@4a531fa5a603bab87dfa56578bd82b28508c9547 # v2.2.2
uses: docker/build-push-action@4a531fa5a603bab87dfa56578bd82b28508c9547
id: docker_build_ci_v1_9
with:
context: .
Expand All @@ -74,12 +74,12 @@ jobs:
# PR updates
- name: Checkout PR Source Code
if: ${{ github.event_name == 'pull_request_target' }}
uses: actions/checkout@5a4ac9002d0be2fb38bd78e4b4dbde5606d7042f # v2.3.4
uses: actions/checkout@5a4ac9002d0be2fb38bd78e4b4dbde5606d7042f
with:
ref: ${{ github.event.pull_request.head.sha }}
- name: CI Build ${{ matrix.name }}
if: ${{ github.event_name == 'pull_request_target' }}
uses: docker/build-push-action@4a531fa5a603bab87dfa56578bd82b28508c9547 # v2.2.2
uses: docker/build-push-action@4a531fa5a603bab87dfa56578bd82b28508c9547
id: docker_build_ci_pr
with:
context: .
Expand All @@ -96,7 +96,7 @@ jobs:
# Upload artifact digests
- name: Upload artifact digests
uses: actions/upload-artifact@e448a9b857ee2131e752b06002bf0e093c65e571 # v2
uses: actions/upload-artifact@e448a9b857ee2131e752b06002bf0e093c65e571
with:
name: image-digest ${{ matrix.name }}
path: image-digest
Expand All @@ -112,7 +112,7 @@ jobs:
run: |
mkdir -p image-digest/
- name: Download digests of all images built
uses: actions/download-artifact@4a7a711286f30c025902c28b541c10e147a9b843 # v2.0.8
uses: actions/download-artifact@4a7a711286f30c025902c28b541c10e147a9b843
with:
path: image-digest/

Expand Down

0 comments on commit 1273c57

Please sign in to comment.