Skip to content

Commit

Permalink
workflows/ipsec: Add missing --flush-ct for key rotation
Browse files Browse the repository at this point in the history
[ upstream commit 751c17c ]

Now that we cover the key rotations in the IPsec e2e tests, we are
running the connectivity test suite twice. That means we can run in the
usual bug where an existing CT entry is reused and leads to us sending
traffic to the proxy when we shouldn't.

Thus, we need to flush the CT entries at the end of the first test run,
with --flush-ct.

Fixes: de192de ("ci-ipsec-e2e: Add IPsec key rotation test")
Signed-off-by: Paul Chaignon <paul.chaignon@gmail.com>
  • Loading branch information
pchaigno authored and jschwinger233 committed Sep 12, 2023
1 parent 30a6674 commit 13a97b0
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion .github/workflows/conformance-ipsec-e2e.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -282,7 +282,8 @@ jobs:
--sysdump-hubble-flows-count=1000000 --sysdump-hubble-flows-timeout=5m \
--sysdump-output-filename "cilium-sysdump-${{ matrix.name }}-<ts>" \
--junit-file "cilium-junits/${{ env.job_name }} (${{ join(matrix.*, ', ') }}).xml" \
--junit-property github_job_step="Run tests (${{ join(matrix.*, ', ') }})"
--junit-property github_job_step="Run tests (${{ join(matrix.*, ', ') }})" \
--flush-ct
- name: Rotate IPsec Key & Test (${{ join(matrix.*, ', ') }})
uses: cilium/cilium/.github/actions/conn-disrupt-test@824192af1ce1672a749a831dd151b3efe92d028a
Expand Down

0 comments on commit 13a97b0

Please sign in to comment.