Skip to content

Commit

Permalink
docs, daemon: Allow EndpointSlices to be used with BGP
Browse files Browse the repository at this point in the history
Following the newly implemented support for EndpointSlices in MetalLB
v0.10.0 (https://metallb.universe.tf/release-notes/#version-0-10-0).

Signed-off-by: Chris Tarazi <chris@isovalent.com>
  • Loading branch information
christarazi committed Jul 16, 2021
1 parent 099b457 commit 1f9752e
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 22 deletions.
11 changes: 0 additions & 11 deletions Documentation/gettingstarted/bgp.rst
Original file line number Diff line number Diff line change
Expand Up @@ -155,14 +155,3 @@ Verify that traffic to the external IP is directed to the backends:
$ # Exec / SSH into BGP router
$ curl 192.0.2.154
Limitations
===========

BGP support relies on MetalLB. Due to the `lack of upstream support
<https://github.com/metallb/metallb/issues/811>`_ for ``EndpointSlices`` in
MetalLB, Cilium will fallback to using the original ``Endpoints`` resource.

The Kubernetes documentation provides a simple `explanation
<https://kubernetes.io/docs/concepts/services-networking/endpoint-slices/>`_ of
the advantages of ``EndpointSlices`` and the issues with ``Endpoints``.
11 changes: 0 additions & 11 deletions daemon/cmd/daemon_main.go
Original file line number Diff line number Diff line change
Expand Up @@ -1442,17 +1442,6 @@ func initEnv(cmd *cobra.Command) {
if option.Config.BGPAnnounceLBIP {
option.Config.EnableNodePort = true
log.Infof("Auto-set BPF NodePort (%q) because LB IP announcements via BGP depend on it.", option.EnableNodePort)

if option.Config.K8sEnableK8sEndpointSlice {
option.Config.K8sEnableK8sEndpointSlice = false
log.WithFields(logrus.Fields{
logfields.URL: "https://github.com/metallb/metallb/issues/811",
}).Warnf(
"Disabling EndpointSlice support (%q) due to incompatibility with BGP mode. "+
"Cilium will fallback to using the original Endpoint resource.",
option.K8sEnableEndpointSlice,
)
}
}
}

Expand Down

0 comments on commit 1f9752e

Please sign in to comment.