Skip to content

Commit

Permalink
bgpv1: Remove a noisy log in Controller
Browse files Browse the repository at this point in the history
Controller generate a log for every single reconciliation. This is noisy
and doesn't make much sense since users doesn't care about
reconciliation happening, but the outcome of the reconciliation.

Signed-off-by: Yutaro Hayakawa <yutaro.hayakawa@isovalent.com>
  • Loading branch information
YutaroHayakawa authored and ti-mo committed Feb 22, 2024
1 parent 54c9341 commit 329fefb
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions pkg/bgpv1/agent/controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,6 @@ func (c *Controller) Run(ctx context.Context) {
l.Info("Cilium BGP Control Plane Controller shut down")
return
case <-c.Sig.Sig:
l.Info("Cilium BGP Control Plane Controller woken for reconciliation")
if err := c.Reconcile(ctx); err != nil {
l.WithError(err).Error("Encountered error during reconciliation")
} else {
Expand Down Expand Up @@ -287,7 +286,6 @@ func (c *Controller) Reconcile(ctx context.Context) error {
if err != nil {
return fmt.Errorf("failed to list CiliumBGPPeeringPolicies")
}
l.WithField("count", len(policies)).Debug("Successfully listed CiliumBGPPeeringPolicies")

// perform policy selection based on node.
labels := c.LocalCiliumNode.Labels
Expand Down Expand Up @@ -315,7 +313,6 @@ func (c *Controller) Reconcile(ctx context.Context) error {
}

// call bgp sub-systems required to apply this policy's BGP topology.
l.Debug("Asking configured BGPRouterManager to configure peering")
if err := c.BGPMgr.ConfigurePeers(ctx, policy, c.LocalCiliumNode); err != nil {
return fmt.Errorf("failed to configure BGP peers, cannot apply BGP peering policy: %w", err)
}
Expand Down

0 comments on commit 329fefb

Please sign in to comment.