Skip to content

Commit

Permalink
docs: Remove non-x86 restriction
Browse files Browse the repository at this point in the history
Remove logic from Documentation/Makefile that skips building
'update-helm-values' on non-x86 platforms. This limitation is no longer
needed as we use the helm toolbox image, which is available for multiple
architectures.

Fixes: #20236
Signed-off-by: Jarno Rajahalme <jarno@isovalent.com>
  • Loading branch information
jrajahalme committed May 12, 2023
1 parent 3a3f135 commit 3965bfd
Showing 1 changed file with 1 addition and 12 deletions.
13 changes: 1 addition & 12 deletions Documentation/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -81,18 +81,7 @@ copy-api:
@$(ECHO_GEN)_api
$(QUIET)cp -r ../api/. _api

# $(HELM_DOCS_IMAGE), necessary to update the reference for Helm values,
# attempts to run a Go binary compiled for x86_64. Skip the update on other
# architectures by making update-helm-values an empty target, unless the user
# passes a compatible image.
HELM_VALUES_DEP := $(HELM_VALUES)
ifneq ($(shell uname -m),x86_64)
ifeq ($(origin HELM_DOCS_IMAGE), file)
$(info Documentation: skipping update for the Helm reference (image needs x86_64))
HELM_VALUES_DEP :=
endif
endif
update-helm-values: $(HELM_VALUES_DEP) ## Update the Helm reference documentation.
update-helm-values: $(HELM_VALUES) ## Update the Helm reference documentation.

HELM_DOCS_ROOT_PATH := $(DOCKER_CTR_ROOT_DIR)
HELM_DOCS_CHARTS_DIR := $(HELM_DOCS_ROOT_PATH)/install/kubernetes
Expand Down

0 comments on commit 3965bfd

Please sign in to comment.