-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
node: Remove node deletion when stopping and wait for background workers
NodeManager's Stop() was earlier only used by tests so it's behavior was to clean up datapath state by calling NodeDelete for each node. This is not the desired behavior as we want to preserve the datapath state when shutting down in order to not disrupt connectivity. This cleanup behavior was never used in any tests and prior this was only triggered by control-plane tests via call to Daemon.Close(), so it's safe to remove this. In addition Stop() did not wait for the backgroundSync() goroutine to exit in Stop(). Fix this by using workerpool. Signed-off-by: Jussi Maki <jussi@isovalent.com>
- Loading branch information
Showing
2 changed files
with
20 additions
and
31 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters