Skip to content

Commit

Permalink
gha: Enable Ingress Controller tests in conformance-e2e
Browse files Browse the repository at this point in the history
The Ingress related connectivity tests are already available in cilium
cli, this commit is to enable the same in conformance e2e tests for some
tests having kpr as true.

Relates: cilium/cilium-cli#1533
Relates: cilium/cilium-cli#2106
Signed-off-by: Tam Mach <tam.mach@cilium.io>
  • Loading branch information
sayboras committed Nov 15, 2023
1 parent 9118468 commit 561ea1c
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 1 deletion.
12 changes: 11 additions & 1 deletion .github/actions/cilium-config/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,9 @@ inputs:
mutual-auth:
description: 'Enable mTLS-based Mutual Authentication'
default: true
ingress-controller:
description: 'Enable ingress controller, required kubeProxyReplacement'
default: false
devices:
description: 'List of native devices to attach datapath programs'
default: ''
Expand Down Expand Up @@ -142,5 +145,12 @@ runs:
HOST_FW="--helm-set=hostFirewall.enabled=true"
fi
CONFIG="${DEFAULTS} ${IMAGE} ${TUNNEL} ${DEVICES} ${LB_MODE} ${ENDPOINT_ROUTES} ${IPV6} ${MASQ} ${EGRESS_GATEWAY} ${ENCRYPT} ${HOST_FW} ${LB_ACCELERATION}"
if [ "${{ inputs.kpr }}" == "true" ]; then
if [ "${{ inputs.ingress-controller }}" == "true" ]; then
INGRESS_CONTROLLER="--helm-set=ingressController.enabled=true"
INGRESS_CONTROLLER+=" --helm-set=ingressController.service.type=NodePort"
fi
fi
CONFIG="${DEFAULTS} ${IMAGE} ${TUNNEL} ${DEVICES} ${LB_MODE} ${ENDPOINT_ROUTES} ${IPV6} ${MASQ} ${EGRESS_GATEWAY} ${ENCRYPT} ${HOST_FW} ${LB_ACCELERATION} ${INGRESS_CONTROLLER}"
echo "config=${CONFIG}" >> $GITHUB_OUTPUT
5 changes: 5 additions & 0 deletions .github/workflows/conformance-e2e.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,7 @@ jobs:
egress-gateway: 'true'
host-fw: 'true'
lb-acceleration: 'testing-only'
ingress-controller: 'true'

- name: '7'
# renovate: datasource=docker depName=quay.io/lvh-images/kind
Expand All @@ -147,6 +148,7 @@ jobs:
lb-mode: 'snat'
egress-gateway: 'true'
lb-acceleration: 'testing-only'
ingress-controller: 'true'

- name: '8'
# renovate: datasource=docker depName=quay.io/lvh-images/kind
Expand Down Expand Up @@ -196,6 +198,7 @@ jobs:
encryption-node: 'true'
lb-mode: 'snat'
egress-gateway: 'true'
ingress-controller: 'true'

- name: '12'
# renovate: datasource=docker depName=quay.io/lvh-images/kind
Expand All @@ -209,6 +212,7 @@ jobs:
encryption-node: 'true'
lb-mode: 'snat'
egress-gateway: 'true'
ingress-controller: 'true'

- name: '13'
# renovate: datasource=docker depName=quay.io/lvh-images/kind
Expand Down Expand Up @@ -257,6 +261,7 @@ jobs:
encryption-node: ${{ matrix.encryption-node }}
egress-gateway: ${{ matrix.egress-gateway }}
host-fw: ${{ matrix.host-fw }}
ingress-controller: ${{ matrix.ingress-controller }}
misc: ${{ matrix.misc }}

# Warning: since this is a privileged workflow, subsequent workflow job
Expand Down

0 comments on commit 561ea1c

Please sign in to comment.