egressgw: avoid multiple updatePoliciesBySourceIP calls

after the switch to the trigger based reconciliation, the reconciliation
can handle multiple type of events in one batch.

Update the logic so that we don't end up calling
updatePoliciesBySourceIP() twice in case we are processing a batch for
both endpoint and policy events.

Co-authored-by: André Martins <andre@cilium.io>
Signed-off-by: Gilberto Bertin <jibi@cilium.io>

pkg/egressgateway/manager.go

@@ -842,20 +842,14 @@ func (manager *Manager) reconcileLocked() {
 		return
 	}
 
-	if manager.eventBitmapIsSet(eventUpdateEndpoint, eventDeleteEndpoint) {
-		manager.updatePoliciesMatchedEndpointIDs()
-		manager.updatePoliciesBySourceIP()
-	}
-
-	if manager.eventBitmapIsSet(eventAddPolicy, eventDeletePolicy) {
-		manager.updatePoliciesBySourceIP()
-	}
-
+	switch {
 	// on eventK8sSyncDone we need to update all caches unconditionally as
 	// we don't know which k8s events/resources were received during the
 	// initial k8s sync
-	if manager.eventBitmapIsSet(eventK8sSyncDone) {
+	case manager.eventBitmapIsSet(eventUpdateEndpoint, eventDeleteEndpoint, eventK8sSyncDone):
 		manager.updatePoliciesMatchedEndpointIDs()
+		fallthrough
+	case manager.eventBitmapIsSet(eventAddPolicy, eventDeletePolicy):
 		manager.updatePoliciesBySourceIP()
 	}