Skip to content

Commit

Permalink
test/verifier: Keep existing environment when running make
Browse files Browse the repository at this point in the history
Don't purge the environment when running `make -C bpf` in the verifier
tests, because unsetting $PATH and $HOME has numerous undesired side
effects:

1. Go is not found in complexity-test little-vm-helper images.
2. Git can't find its config in complexity-test LVH images.
3. The user can't override the path to clang.

Signed-off-by: Maxim Mikityanskiy <maxim@isovalent.com>
  • Loading branch information
gentoo-root authored and julianwiedmann committed Mar 27, 2024
1 parent 283cb04 commit 60e7212
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion test/verifier/verifier_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ func TestVerifier(t *testing.T) {
name := fmt.Sprintf("%s_%s", bpfProgram.name, configName)
cmd := exec.Command("make", "-C", "bpf", "clean", fmt.Sprintf("%s.o", bpfProgram.name))
cmd.Dir = *ciliumBasePath
cmd.Env = append(cmd.Env,
cmd.Env = append(os.Environ(),
fmt.Sprintf("%s=%s", bpfProgram.macroName, datapathConfig),
fmt.Sprintf("KERNEL=%s", kernelVersion),
)
Expand Down

0 comments on commit 60e7212

Please sign in to comment.