Skip to content

Commit

Permalink
fixup! chart: fix hubble tls generation with certmanager
Browse files Browse the repository at this point in the history
Signed-off-by: Valentin Flaux <valentin_flaux@connect-tech.sncf>
  • Loading branch information
vflaux committed Mar 28, 2023
1 parent 65404d2 commit 63d9843
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 4 deletions.
5 changes: 3 additions & 2 deletions install/kubernetes/cilium/README.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,12 @@ metadata:
name: hubble-ca
namespace: {{ .Release.Namespace }}
spec:
commonName: Cilium CA
commonName: Hubble CA
duration: {{ printf "%dh0m0s" (mul .Values.hubble.tls.auto.issuerCertValidityDuration 24) }}
isCA: true
privateKey:
algorithm: ECDSA
size: 256
issuerRef:
group: cert-manager.io
kind: Issuer
Expand Down
1 change: 0 additions & 1 deletion install/kubernetes/cilium/values.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions install/kubernetes/cilium/values.yaml.tmpl
Original file line number Diff line number Diff line change
Expand Up @@ -993,6 +993,9 @@ hubble:
# -- certmanager issuer used when hubble.tls.auto.method=certmanager.
# If not specified, a CA issuer will be created.
certManagerIssuerRef: {}
# -- Generated CA certificate validity duration in days for the Issuer.
# Only used if certManagerIssuerRef is not specified.
issuerCertValidityDuration: 26280

# -- Deprecated in favor of tls.ca. To be removed in 1.13.
# base64 encoded PEM values for the Hubble CA certificate and private key.
Expand Down

0 comments on commit 63d9843

Please sign in to comment.