Skip to content

Commit

Permalink
Makefile fix kind-install-cilium-fast target
Browse files Browse the repository at this point in the history
The kind-install-cilium-fast should install Cilium on all available
kind clusters.

Fixes: 5f88bbf ("docs: Add Makefile and documentation for "fast" development targets")
Signed-off-by: André Martins <andre@cilium.io>
  • Loading branch information
aanm committed Oct 5, 2023
1 parent 5741606 commit 6ea3ed5
Showing 1 changed file with 7 additions and 12 deletions.
19 changes: 7 additions & 12 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -575,18 +575,13 @@ endif
.PHONY: kind-install-cilium-fast
kind-install-cilium-fast: kind-ready ## Install a local Cilium version into the cluster.
@echo " INSTALL cilium"
# cilium-cli doesn't support idempotent installs, so we uninstall and
# reinstall here. https://github.com/cilium/cilium-cli/issues/205
-@$(CILIUM_CLI) uninstall >/dev/null 2>&1 || true

# cilium-cli's --wait flag doesn't work, so we just force it to run
# in the background instead and wait for the resources to be available.
# https://github.com/cilium/cilium-cli/issues/1070
$(CILIUM_CLI) install \
--chart-directory=$(ROOT_DIR)/install/kubernetes/cilium \
$(KIND_VALUES_FAST_FILES) \
--version= \
>/dev/null 2>&1 &
for cluster_name in $${KIND_CLUSTERS:-$(shell kind get clusters)}; do \
$(CILIUM_CLI) --context=kind-$$cluster_name uninstall >/dev/null 2>&1 || true; \
$(CILIUM_CLI) install --context=kind-$$cluster_name \
--chart-directory=$(ROOT_DIR)/install/kubernetes/cilium \
$(KIND_VALUES_FAST_FILES) \
--version= >/dev/null 2>&1 & \
done

.PHONY: build-cli
build-cli: ## Build cilium cli binary
Expand Down

0 comments on commit 6ea3ed5

Please sign in to comment.