Skip to content

Commit

Permalink
helm: Always delete AWS iptable rules
Browse files Browse the repository at this point in the history
This change causes Cilium DaemonSet postStart hook to always delete AWS
iptable rules unless `cni.chainingMode` is set to `aws-cni`.

This will result in the postStart hook being a noop in all non-AWS
deployments. Unfortunately there is no way for helm chart to know
whether it is running on AWS not in ENI mode.

This approach will make sure that we are deleting AWS-specific iptables
rules that cause issues while not requiring us to introduce new
configuration flags for users.

Signed-off-by: Maciej Kwiek <maciej@isovalent.com>
  • Loading branch information
nebril committed Oct 26, 2023
1 parent 7a4c5fb commit 74632a5
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,7 @@ spec:
{{- end }}
{{- if .Values.cni.install }}
lifecycle:
{{- if .Values.eni.enabled }}
{{- if ne .Values.cni.chainingMode "aws-cni" }}
postStart:
exec:
command:
Expand Down

0 comments on commit 74632a5

Please sign in to comment.