helm: set cni.uninstall default to false

Don't delete the CNI configuration file when stopping the agent. This has several important effects: - the node no longer goes NotReady, so it won't be removed from cloud LB backends just because cilium is being upgraded - CNI DEL will still succeed, so pods can always be cleaned up - No chance of pods being started with a different CNI provider Signed-off-by: Casey Callendrello <cdc@isovalent.com>
cilium · Mar 21, 2023 · 7758b3e · 7758b3e
1 parent d890a88
commit 7758b3e
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/Documentation/helm-values.rst b/Documentation/helm-values.rst
diff --git a/install/kubernetes/cilium/README.md b/install/kubernetes/cilium/README.md
diff --git a/install/kubernetes/cilium/values.yaml b/install/kubernetes/cilium/values.yaml
diff --git a/install/kubernetes/cilium/values.yaml.tmpl b/install/kubernetes/cilium/values.yaml.tmpl
@@ -469,7 +469,7 @@ cni:
   # if you're removing Cilium from the cluster. Disable this to prevent the CNI
   # configuration file from being removed during agent upgrade, which can cause
   # nodes to go unmanageable.
-  uninstall: true
+  uninstall: false
 
   # -- Configure chaining on top of other CNI plugins. Possible values:
   #  - none