Skip to content

Commit

Permalink
.github: Rename failure step in actions
Browse files Browse the repository at this point in the history
Currently, the way that GitHub renders failing jobs here is that the
"Install cilium chart" step will fail, then the "Capture cilium-sysdump"
step will be collapsed. Recently we added `cilium status` output into
this step, but unless developers know to click on this step and expand
the output to investigate the cluster status, it's not obvious whether
the failure is a random CI issue or whether there is some cause related
to their changes.

Renaming the failure step here will hopefully give a slightly better
signal to developers when a failure is caused by their changes, and that
they should take a closer look at the sysdump to confirm the failure
condition.

Signed-off-by: Joe Stringer <joe@cilium.io>
  • Loading branch information
joestringer committed Mar 21, 2023
1 parent b2bc42a commit 7d2b69f
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/conformance-k8s-network-policies.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ jobs:
working-directory: test/k8s/manifests/netpol-cyclonus
run: ./test-cyclonus.sh

- name: Capture cilium-sysdump
- name: Report cluster failure status and capture cilium-sysdump
if: ${{ failure() }}
run: |
echo "=== Install Cilium CLI ==="
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/tests-smoke-ipv6.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ jobs:
kubectl apply -f ${{ env.CONFORMANCE_TEMPLATE }}
kubectl wait --for=condition=Available --all deployment --timeout=${{ env.TIMEOUT }}
- name: Capture cilium-sysdump
- name: Report cluster failure status and capture cilium-sysdump
if: ${{ failure() }}
# The following is needed to prevent hubble from receiving an empty
# file (EOF) on stdin and displaying no flows.
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/tests-smoke.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@ jobs:
sudo mv prometheus-${PROM_VERSION}.linux-amd64/promtool /usr/bin
cat metrics.prom | promtool check metrics
- name: Capture cilium-sysdump
- name: Report cluster failure status and capture cilium-sysdump
if: ${{ failure() }}
# The following is needed to prevent hubble from receiving an empty
# file (EOF) on stdin and displaying no flows.
Expand Down

0 comments on commit 7d2b69f

Please sign in to comment.