Skip to content

Commit

Permalink
dev-doctor: Bump minimum hub version requirement for backporting
Browse files Browse the repository at this point in the history
Backporting scripts need a version of github.com/github/hub that support
the api command. The version of hub distributed with Ubuntu 20.04 LTS is
2.7.0, which is too old. Bump the minimum hub version to 2.14 as this is
definitely new enough and was released 18 months ago.

Signed-off-by: Tom Payne <tom@isovalent.com>
  • Loading branch information
twpayne authored and aditighag committed Jul 8, 2021
1 parent 9c80044 commit 817d1e8
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion tools/dev-doctor/rootcmd.go
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,8 @@ func rootCmdRun(cmd *cobra.Command, args []string) {
ifNotFound: checkError,
versionArgs: []string{"--version"},
versionRegexp: regexp.MustCompile(`hub\s+version\s+(\d+.\d+\.\d+)`),
minVersion: &semver.Version{Major: 2, Minor: 0, Patch: 0},
minVersion: &semver.Version{Major: 2, Minor: 14, Patch: 0},
hint: `Download the latest version from https://github.com/github/hub/releases.`,
},
&envVarCheck{
name: "GITHUB_TOKEN",
Expand Down

0 comments on commit 817d1e8

Please sign in to comment.