Skip to content

Commit

Permalink
test: Add Error Log Exceptions
Browse files Browse the repository at this point in the history
Occasionally the cilium-operator will run into a transient issue
where it cannot get/update/release the leaselock with K8s that
it uses to adjudicate its leader election. This error message
is part and parcel of this failure and can be ignored.

cf. #16402

Signed-off-by: Nate Sweet <nathanjsweet@pm.me>
  • Loading branch information
nathanjsweet authored and nbusseneau committed Dec 9, 2021
1 parent 2ae7af6 commit 82d4422
Showing 1 changed file with 9 additions and 8 deletions.
17 changes: 9 additions & 8 deletions test/helpers/cons.go
Original file line number Diff line number Diff line change
Expand Up @@ -232,13 +232,14 @@ const (
missingIptablesWait = "Missing iptables wait arg (-w):"

// ...and their exceptions.
lrpExists = "local-redirect service exists for frontend" // cf. https://github.com/cilium/cilium/issues/16400
opCantBeFulfilled = "Operation cannot be fulfilled on leases.coordination.k8s.io" // cf. https://github.com/cilium/cilium/issues/16402
initLeaderElection = "error initially creating leader election record: leases." // cf. https://github.com/cilium/cilium/issues/16402#issuecomment-861544964
globalDataSupport = "kernel doesn't support global data" // cf. https://github.com/cilium/cilium/issues/16418
removeInexistentID = "removing identity not added to the identity manager!" // cf. https://github.com/cilium/cilium/issues/16419
failedToListCRDs = "the server could not find the requested resource" // cf. https://github.com/cilium/cilium/issues/16425
retrieveResLock = "retrieving resource lock kube-system/cilium-operator-resource-lock" // cf. https://github.com/cilium/cilium/issues/16402#issuecomment-871155492
lrpExists = "local-redirect service exists for frontend" // cf. https://github.com/cilium/cilium/issues/16400
opCantBeFulfilled = "Operation cannot be fulfilled on leases.coordination.k8s.io" // cf. https://github.com/cilium/cilium/issues/16402
initLeaderElection = "error initially creating leader election record: leases." // cf. https://github.com/cilium/cilium/issues/16402#issuecomment-861544964
globalDataSupport = "kernel doesn't support global data" // cf. https://github.com/cilium/cilium/issues/16418
removeInexistentID = "removing identity not added to the identity manager!" // cf. https://github.com/cilium/cilium/issues/16419
failedToListCRDs = "the server could not find the requested resource" // cf. https://github.com/cilium/cilium/issues/16425
retrieveResLock = "retrieving resource lock kube-system/cilium-operator-resource-lock" // cf. https://github.com/cilium/cilium/issues/16402#issuecomment-871155492
failedToRelLockEmptyName = "Failed to release lock: resource name may not be empty" // cf. https://github.com/cilium/cilium/issues/16402#issuecomment-985819560

// HelmTemplate is the location of the Helm templates to install Cilium
HelmTemplate = "../install/kubernetes/cilium"
Expand Down Expand Up @@ -304,7 +305,7 @@ var badLogMessages = map[string][]string{
"DATA RACE": nil,
// Exceptions for level=error should only be added as a last resort, if the
// error cannot be fixed in Cilium or in the test.
"level=error": {lrpExists, opCantBeFulfilled, initLeaderElection, globalDataSupport, removeInexistentID, failedToListCRDs, retrieveResLock},
"level=error": {lrpExists, opCantBeFulfilled, initLeaderElection, globalDataSupport, removeInexistentID, failedToListCRDs, retrieveResLock, failedToRelLockEmptyName},
}

var ciliumCLICommands = map[string]string{
Expand Down

0 comments on commit 82d4422

Please sign in to comment.