Skip to content

Commit

Permalink
gke: Don't use preemptible instances
Browse files Browse the repository at this point in the history
Similar to EKS, money is not a concern here so let's not bother with
preemptible instances.

Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
  • Loading branch information
michi-covalent authored and aanm committed May 16, 2024
1 parent 580d31b commit 83e5a9e
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 7 deletions.
5 changes: 1 addition & 4 deletions .github/workflows/conformance-externalworkloads.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,6 @@ jobs:
timeout-minutes: 45
env:
job_name: "Installation and Connectivity Test"
preemptible: ${{ github.event_name != 'schedule' && '--preemptible' || '' }}
strategy:
fail-fast: false
matrix: ${{fromJson(needs.generate-matrix.outputs.matrix)}}
Expand Down Expand Up @@ -224,7 +223,6 @@ jobs:
--machine-type e2-custom-2-4096 \
--boot-disk-type pd-standard \
--boot-disk-size 10GB \
${{ env.preemptible }} \
--image-project ubuntu-os-cloud \
--image-family ubuntu-2004-lts \
--metadata hostname=${{ env.vmName }}-${{ matrix.vmIndex }} \
Expand All @@ -244,8 +242,7 @@ jobs:
--num-nodes 2 \
--machine-type e2-custom-2-4096 \
--disk-type pd-standard \
--disk-size 20GB \
${{ env.preemptible }}
--disk-size 20GB
- name: Get cluster credentials
run: |
Expand Down
4 changes: 1 addition & 3 deletions .github/workflows/conformance-gke.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,6 @@ jobs:
timeout-minutes: 75
env:
job_name: "Installation and Connectivity Test"
preemptible: ${{ github.event_name != 'schedule' && '--preemptible' || '' }}
strategy:
fail-fast: false
matrix: ${{fromJson(needs.generate-matrix.outputs.matrix)}}
Expand Down Expand Up @@ -228,8 +227,7 @@ jobs:
--machine-type e2-custom-2-4096 \
--disk-type pd-standard \
--disk-size 20GB \
--node-taints ignore-taint.cluster-autoscaler.kubernetes.io/cilium-agent-not-ready=true:NoExecute \
${{ env.preemptible }}
--node-taints ignore-taint.cluster-autoscaler.kubernetes.io/cilium-agent-not-ready=true:NoExecute
- name: Get cluster credentials
run: |
Expand Down

0 comments on commit 83e5a9e

Please sign in to comment.