Skip to content

Commit

Permalink
gh: workflows: clarify reference to issue #23283
Browse files Browse the repository at this point in the history
Clarify that while the issue was closed as resolved, this actually only
applies to scenarios where the kind.sh script is used.

Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
  • Loading branch information
julianwiedmann authored and YutaroHayakawa committed Mar 15, 2024
1 parent f61651f commit 8c23fa8
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 3 deletions.
3 changes: 2 additions & 1 deletion .github/workflows/conformance-clustermesh.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -336,7 +336,8 @@ jobs:
# Make sure that coredns uses IPv4-only upstream DNS servers also in case of clusters
# with IP family dual, since IPv6 ones are not reachable and cause spurious failures.
# Additionally, this is also required to workaround #23283.
# Additionally, this is also required to workaround
# https://github.com/cilium/cilium/issues/23283#issuecomment-1597282247.
- name: Configure the coredns nameservers
run: |
COREDNS_PATCH="
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/conformance-multi-pool.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,8 @@ jobs:
# - Multi-pool IPAM only supports endpoint routes, thus we disable
# the local-node-route.
# - helm/kind-action does not support BPF host routing, so we fall
# back on legacy host routing (#23283)
# back on legacy host routing
# (https://github.com/cilium/cilium/issues/23283#issuecomment-1597282247)
# - iptables-based masquerading does not support multiple non-masquerade
# CIDRs. Thus, we enable BPF masquerading where we can add multiple
# non-masquerade CIDRs.
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/tests-clustermesh-upgrade.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,8 @@ jobs:

# Make sure that coredns uses IPv4-only upstream DNS servers also in case of clusters
# with IP family dual, since IPv6 ones are not reachable and cause spurious failures.
# Additionally, this is also required to workaround #23283.
# Additionally, this is also required to workaround
# https://github.com/cilium/cilium/issues/23283#issuecomment-1597282247.
- name: Configure the coredns nameservers
run: |
COREDNS_PATCH="
Expand Down

0 comments on commit 8c23fa8

Please sign in to comment.