Skip to content

Commit

Permalink
ci: default external flags in ConformanceKindEnvoyDaemonSet
Browse files Browse the repository at this point in the history
This commit removes the flags `external-*` from the connectivity tests
in ConformanceKindEnvoyDaemonSet. Therefore the defaults are used.

This should stabilize the execution of the check on GHA.

Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
  • Loading branch information
mhofstetter authored and joestringer committed Jun 15, 2023
1 parent 6ff2eac commit 8f360b4
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions .github/workflows/conformance-kind-proxy-daemonset.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -76,8 +76,7 @@ jobs:
--helm-set=bpf.monitorAggregation="none" \
--wait=false \
--version="
CONNECTIVITY_TEST_DEFAULTS="--flow-validation=disabled --hubble=false --collect-sysdump-on-failure \
--external-target bing.com --external-cidr 8.0.0.0/8 --external-ip 8.8.8.8 --external-other-ip 8.8.4.4"
CONNECTIVITY_TEST_DEFAULTS="--flow-validation=disabled --hubble=false --collect-sysdump-on-failure"
echo cilium_install_defaults=${CILIUM_INSTALL_DEFAULTS} >> $GITHUB_OUTPUT
echo connectivity_test_defaults=${CONNECTIVITY_TEST_DEFAULTS} >> $GITHUB_OUTPUT
echo sha=${SHA} >> $GITHUB_OUTPUT
Expand Down

0 comments on commit 8f360b4

Please sign in to comment.