Skip to content

Commit

Permalink
helm: Allow nodeport allocation for Ingress LB svc
Browse files Browse the repository at this point in the history
This commit is to make sure that users can have option to disable node
port allocation for LB service used by Ingress.

https://kubernetes.io/docs/concepts/services-networking/service/#load-balancer-nodeport-allocation
Signed-off-by: Tam Mach <tam.mach@cilium.io>
  • Loading branch information
sayboras committed Jul 12, 2023
1 parent 40a0fc3 commit 908ceeb
Show file tree
Hide file tree
Showing 6 changed files with 17 additions and 2 deletions.
6 changes: 5 additions & 1 deletion Documentation/helm-values.rst

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions Documentation/spelling_wordlist.txt
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,7 @@ Zannoni
Zhou
aarch
alibabacloud
allocateLoadBalancerNodePorts
allocator
allocators
allowedConfigOverrides
Expand Down
3 changes: 2 additions & 1 deletion install/kubernetes/cilium/README.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,9 @@ spec:
{{- if .Values.ingressController.service.loadBalancerClass }}
loadBalancerClass: {{ .Values.ingressController.service.loadBalancerClass }}
{{- end }}
{{- if (not (kindIs "invalid" .Values.ingressController.service.allocateLoadBalancerNodePorts)) }}
allocateLoadBalancerNodePorts: {{ .Values.ingressController.service.allocateLoadBalancerNodePorts }}
{{- end }}
{{- end -}}
{{- if .Values.ingressController.service.loadBalancerIP }}
loadBalancerIP: {{ .Values.ingressController.service.loadBalancerIP }}
Expand Down
3 changes: 3 additions & 0 deletions install/kubernetes/cilium/values.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions install/kubernetes/cilium/values.yaml.tmpl
Original file line number Diff line number Diff line change
Expand Up @@ -743,6 +743,9 @@ ingressController:
loadBalancerClass: ~
# -- Configure a specific loadBalancerIP on the shared LB service
loadBalancerIP : ~
# -- Configure if node port allocation is required for LB service
# ref: https://kubernetes.io/docs/concepts/services-networking/service/#load-balancer-nodeport-allocation
allocateLoadBalancerNodePorts: ~

gatewayAPI:
# -- Enable support for Gateway API in cilium
Expand Down

0 comments on commit 908ceeb

Please sign in to comment.