Skip to content

Commit

Permalink
test/helpers: Disable NodePort health checks if using kube-proxy
Browse files Browse the repository at this point in the history
In the 4.19 CI job, we run with KPR=strict for most tests even though
kube-proxy is installed. As a result, we get an error message because
the agent fails to listen on the health checks port. In that setup, we
should instead disable health checks.

Signed-off-by: Paul Chaignon <paul@cilium.io>
  • Loading branch information
pchaigno authored and aditighag committed Jun 10, 2021
1 parent d547a0b commit 90a1b60
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions test/helpers/kubectl.go
Original file line number Diff line number Diff line change
Expand Up @@ -2360,6 +2360,12 @@ func (kub *Kubectl) overwriteHelmOptions(options map[string]string) error {
"kubeProxyReplacement": "strict",
}

if RunsWithKubeProxy() {
// If kube-proxy is running, we need to disable NodePort health
// checks to avoid an error message.
opts["nodePort.enableHealthCheck"] = "false"
}

if DoesNotRunOnGKE() {
nodeIP, err := kub.GetNodeIPByLabel(K8s1, false)
if err != nil {
Expand Down

0 comments on commit 90a1b60

Please sign in to comment.