Skip to content

Commit

Permalink
ci/workflows: fix sysdump file creation
Browse files Browse the repository at this point in the history
Currently conformance tests that runs in matrix strategy do not create
sysdump files with a uniq name. Only one report is uploaded in github
artifacts. This changes sysdump files names uniq per matrix run.

Signed-off-by: Birol Bilgin <birol@cilium.io>
  • Loading branch information
brlbil committed Jun 21, 2023
1 parent f75b0e8 commit 9431cbf
Show file tree
Hide file tree
Showing 24 changed files with 32 additions and 32 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/conformance-aks-v1.11.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -390,7 +390,7 @@ jobs:
run: |
kubectl get pods --all-namespaces -o wide
cilium status
cilium sysdump --output-filename cilium-sysdump-final
cilium sysdump --output-filename cilium-sysdump-final-${{ join(matrix.*, '-') }}
shell: bash {0} # Disable default fail-fast behaviour so that all commands run independently

- name: Clean up AKS
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/conformance-aks-v1.12.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -392,7 +392,7 @@ jobs:
run: |
kubectl get pods --all-namespaces -o wide
cilium status
cilium sysdump --output-filename cilium-sysdump-final
cilium sysdump --output-filename cilium-sysdump-final-${{ join(matrix.*, '-') }}
shell: bash {0} # Disable default fail-fast behaviour so that all commands run independently

- name: Clean up AKS
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/conformance-aks-v1.13.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -392,7 +392,7 @@ jobs:
run: |
kubectl get pods --all-namespaces -o wide
cilium status
cilium sysdump --output-filename cilium-sysdump-final
cilium sysdump --output-filename cilium-sysdump-final-${{ join(matrix.*, '-') }}
shell: bash {0} # Disable default fail-fast behaviour so that all commands run independently

- name: Clean up AKS
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/conformance-aks.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -390,7 +390,7 @@ jobs:
run: |
kubectl get pods --all-namespaces -o wide
cilium status
cilium sysdump --output-filename cilium-sysdump-final
cilium sysdump --output-filename cilium-sysdump-final-${{ join(matrix.*, '-') }}
shell: bash {0} # Disable default fail-fast behaviour so that all commands run independently

- name: Clean up AKS
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/conformance-aws-cni-v1.11.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -361,7 +361,7 @@ jobs:
echo "=== Retrieve cluster state ==="
kubectl get pods --all-namespaces -o wide
cilium status
cilium sysdump --output-filename cilium-sysdump-final
cilium sysdump --output-filename cilium-sysdump-final-${{ join(matrix.*, '-') }}
shell: bash {0} # Disable default fail-fast behaviour so that all commands run independently

- name: Clean up EKS
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/conformance-aws-cni-v1.12.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -361,7 +361,7 @@ jobs:
echo "=== Retrieve cluster state ==="
kubectl get pods --all-namespaces -o wide
cilium status
cilium sysdump --output-filename cilium-sysdump-final
cilium sysdump --output-filename cilium-sysdump-final-${{ join(matrix.*, '-') }}
shell: bash {0} # Disable default fail-fast behaviour so that all commands run independently

- name: Clean up EKS
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/conformance-aws-cni-v1.13.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -361,7 +361,7 @@ jobs:
echo "=== Retrieve cluster state ==="
kubectl get pods --all-namespaces -o wide
cilium status
cilium sysdump --output-filename cilium-sysdump-final
cilium sysdump --output-filename cilium-sysdump-final-${{ join(matrix.*, '-') }}
shell: bash {0} # Disable default fail-fast behaviour so that all commands run independently

- name: Clean up EKS
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/conformance-aws-cni.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -350,7 +350,7 @@ jobs:
echo "=== Retrieve cluster state ==="
kubectl get pods --all-namespaces -o wide
cilium status
cilium sysdump --output-filename cilium-sysdump-final
cilium sysdump --output-filename cilium-sysdump-final-${{ join(matrix.*, '-') }}
shell: bash {0} # Disable default fail-fast behaviour so that all commands run independently

- name: Clean up EKS
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/conformance-clustermesh-v1.11.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -519,18 +519,18 @@ jobs:
kubectl config use-context ${{ env.contextName1 }}
kubectl get pods --all-namespaces -o wide
cilium sysdump --output-filename cilium-sysdump-context1-final
cilium sysdump --output-filename cilium-sysdump-context1-final-${{ join(matrix.*, '-') }}
kubectl config use-context ${{ env.contextName2 }}
kubectl get pods --all-namespaces -o wide
cilium sysdump --output-filename cilium-sysdump-context2-final
cilium sysdump --output-filename cilium-sysdump-context2-final-${{ join(matrix.*, '-') }}
shell: bash {0} # Disable default fail-fast behaviour so that all commands run independently

- name: Upload artifacts
if: ${{ !success() }}
uses: actions/upload-artifact@0b7f8abb1508181956e8e162db84b466c27e18ce # v3.1.2
with:
name: cilium-sysdumps-${{ matrix.name }}
name: cilium-sysdumps
path: cilium-sysdump-*.zip
retention-days: 5

Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/conformance-clustermesh-v1.12.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -514,18 +514,18 @@ jobs:
kubectl config use-context ${{ env.contextName1 }}
kubectl get pods --all-namespaces -o wide
cilium sysdump --output-filename cilium-sysdump-context1-final
cilium sysdump --output-filename cilium-sysdump-context1-final-${{ join(matrix.*, '-') }}
kubectl config use-context ${{ env.contextName2 }}
kubectl get pods --all-namespaces -o wide
cilium sysdump --output-filename cilium-sysdump-context2-final
cilium sysdump --output-filename cilium-sysdump-context2-final-${{ join(matrix.*, '-') }}
shell: bash {0} # Disable default fail-fast behaviour so that all commands run independently

- name: Upload artifacts
if: ${{ !success() }}
uses: actions/upload-artifact@0b7f8abb1508181956e8e162db84b466c27e18ce # v3.1.2
with:
name: cilium-sysdumps-${{ matrix.name }}
name: cilium-sysdumps
path: cilium-sysdump-*.zip
retention-days: 5

Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/conformance-clustermesh-v1.13.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -514,18 +514,18 @@ jobs:
kubectl config use-context ${{ env.contextName1 }}
kubectl get pods --all-namespaces -o wide
cilium sysdump --output-filename cilium-sysdump-context1-final
cilium sysdump --output-filename cilium-sysdump-context1-${{ join(matrix.*, '-') }}
kubectl config use-context ${{ env.contextName2 }}
kubectl get pods --all-namespaces -o wide
cilium sysdump --output-filename cilium-sysdump-context2-final
cilium sysdump --output-filename cilium-sysdump-context2-final-${{ join(matrix.*, '-') }}
shell: bash {0} # Disable default fail-fast behaviour so that all commands run independently

- name: Upload artifacts
if: ${{ !success() }}
uses: actions/upload-artifact@0b7f8abb1508181956e8e162db84b466c27e18ce # v3.1.2
with:
name: cilium-sysdumps-${{ matrix.name }}
name: cilium-sysdumps
path: cilium-sysdump-*.zip
retention-days: 5

Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/conformance-clustermesh.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -504,18 +504,18 @@ jobs:
kubectl config use-context ${{ env.contextName1 }}
kubectl get pods --all-namespaces -o wide
cilium sysdump --output-filename cilium-sysdump-context1-final
cilium sysdump --output-filename cilium-sysdump-context1-final-${{ join(matrix.*, '-') }}
kubectl config use-context ${{ env.contextName2 }}
kubectl get pods --all-namespaces -o wide
cilium sysdump --output-filename cilium-sysdump-context2-final
cilium sysdump --output-filename cilium-sysdump-context2-final-${{ join(matrix.*, '-') }}
shell: bash {0} # Disable default fail-fast behaviour so that all commands run independently

- name: Upload artifacts
if: ${{ !success() }}
uses: actions/upload-artifact@0b7f8abb1508181956e8e162db84b466c27e18ce # v3.1.2
with:
name: cilium-sysdumps-${{ matrix.name }}
name: cilium-sysdumps
path: cilium-sysdump-*.zip
retention-days: 5

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/conformance-eks-v1.11.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -381,7 +381,7 @@ jobs:
run: |
kubectl get pods --all-namespaces -o wide
cilium status
cilium sysdump --output-filename cilium-sysdump-final
cilium sysdump --output-filename cilium-sysdump-final-${{ join(matrix.*, "-") }}
shell: bash {0} # Disable default fail-fast behaviour so that all commands run independently

- name: Clean up EKS
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/conformance-eks-v1.12.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -381,7 +381,7 @@ jobs:
run: |
kubectl get pods --all-namespaces -o wide
cilium status
cilium sysdump --output-filename cilium-sysdump-final
cilium sysdump --output-filename cilium-sysdump-final-${{ join(matrix.*, "-") }}
shell: bash {0} # Disable default fail-fast behaviour so that all commands run independently

- name: Clean up EKS
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/conformance-eks-v1.13.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -381,7 +381,7 @@ jobs:
run: |
kubectl get pods --all-namespaces -o wide
cilium status
cilium sysdump --output-filename cilium-sysdump-final
cilium sysdump --output-filename cilium-sysdump-final-${{ join(matrix.*, "-") }}
shell: bash {0} # Disable default fail-fast behaviour so that all commands run independently

- name: Clean up EKS
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/conformance-eks.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -373,7 +373,7 @@ jobs:
run: |
kubectl get pods --all-namespaces -o wide
cilium status
cilium sysdump --output-filename cilium-sysdump-final
cilium sysdump --output-filename cilium-sysdump-final-${{ join(matrix.*, "-") }}
shell: bash {0} # Disable default fail-fast behaviour so that all commands run independently

- name: Clean up EKS
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/conformance-externalworkloads-v1.11.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -408,7 +408,7 @@ jobs:
cilium clustermesh vm status
gcloud compute ssh ${{ env.vmName }}-${{ matrix.vmIndex }} --zone ${{ matrix.zone }} --command "sudo cilium status"
gcloud compute ssh ${{ env.vmName }}-${{ matrix.vmIndex }} --zone ${{ matrix.zone }} --command "sudo docker logs cilium --timestamps"
cilium sysdump --output-filename cilium-sysdump-final
cilium sysdump --output-filename cilium-sysdump-final-${{ join(matrix.*, '-') }}
shell: bash {0} # Disable default fail-fast behaviour so that all commands run independently

- name: Clean up GKE cluster and VM
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/conformance-externalworkloads-v1.12.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -408,7 +408,7 @@ jobs:
cilium clustermesh vm status
gcloud compute ssh ${{ env.vmName }}-${{ matrix.vmIndex }} --zone ${{ matrix.zone }} --command "sudo cilium status"
gcloud compute ssh ${{ env.vmName }}-${{ matrix.vmIndex }} --zone ${{ matrix.zone }} --command "sudo docker logs cilium --timestamps"
cilium sysdump --output-filename cilium-sysdump-final
cilium sysdump --output-filename cilium-sysdump-final-${{ join(matrix.*, '-') }}
shell: bash {0} # Disable default fail-fast behaviour so that all commands run independently

- name: Clean up GKE cluster and VM
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/conformance-externalworkloads-v1.13.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -408,7 +408,7 @@ jobs:
cilium clustermesh vm status
gcloud compute ssh ${{ env.vmName }}-${{ matrix.vmIndex }} --zone ${{ matrix.zone }} --command "sudo cilium status"
gcloud compute ssh ${{ env.vmName }}-${{ matrix.vmIndex }} --zone ${{ matrix.zone }} --command "sudo docker logs cilium --timestamps"
cilium sysdump --output-filename cilium-sysdump-final
cilium sysdump --output-filename cilium-sysdump-final-${{ join(matrix.*, '-') }}
shell: bash {0} # Disable default fail-fast behaviour so that all commands run independently

- name: Clean up GKE cluster and VM
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/conformance-externalworkloads.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -404,7 +404,7 @@ jobs:
cilium clustermesh vm status
gcloud compute ssh ${{ env.vmName }}-${{ matrix.vmIndex }} --zone ${{ matrix.zone }} --command "sudo cilium status"
gcloud compute ssh ${{ env.vmName }}-${{ matrix.vmIndex }} --zone ${{ matrix.zone }} --command "sudo docker logs cilium --timestamps"
cilium sysdump --output-filename cilium-sysdump-final
cilium sysdump --output-filename cilium-sysdump-final-${{ join(matrix.*, '-') }}
shell: bash {0} # Disable default fail-fast behaviour so that all commands run independently

- name: Clean up GKE cluster and VM
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/conformance-gke-v1.11.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -370,7 +370,7 @@ jobs:
run: |
kubectl get pods --all-namespaces -o wide
cilium status
cilium sysdump --output-filename cilium-sysdump-final
cilium sysdump --output-filename cilium-sysdump-final-${{ matrix.k8s.version }}-${{ matrix.config.index }}-${{ matrix.config.type }}
shell: bash {0} # Disable default fail-fast behaviour so that all commands run independently

- name: Clean up GKE
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/conformance-gke-v1.12.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -370,7 +370,7 @@ jobs:
run: |
kubectl get pods --all-namespaces -o wide
cilium status
cilium sysdump --output-filename cilium-sysdump-final
cilium sysdump --output-filename cilium-sysdump-final-${{ matrix.k8s.version }}-${{ matrix.config.index }}-${{ matrix.config.type }}
shell: bash {0} # Disable default fail-fast behaviour so that all commands run independently

- name: Clean up GKE
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/conformance-gke-v1.13.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -371,7 +371,7 @@ jobs:
run: |
kubectl get pods --all-namespaces -o wide
cilium status
cilium sysdump --output-filename cilium-sysdump-final
cilium sysdump --output-filename cilium-sysdump-final-${{ matrix.k8s.version }}-${{ matrix.config.index }}-${{ matrix.config.type }}
shell: bash {0} # Disable default fail-fast behaviour so that all commands run independently

- name: Clean up GKE
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/conformance-gke.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -367,7 +367,7 @@ jobs:
run: |
kubectl get pods --all-namespaces -o wide
cilium status
cilium sysdump --output-filename cilium-sysdump-final
cilium sysdump --output-filename cilium-sysdump-final-${{ matrix.k8s.version }}-${{ matrix.config.index }}-${{ matrix.config.type }}
shell: bash {0} # Disable default fail-fast behaviour so that all commands run independently

- name: Clean up GKE
Expand Down

0 comments on commit 9431cbf

Please sign in to comment.