Skip to content

Commit

Permalink
gha: Remove manual device setting
Browse files Browse the repository at this point in the history
This is in favour of recent work on auto device detection.

Signed-off-by: Tam Mach <tam.mach@cilium.io>
  • Loading branch information
sayboras committed Mar 18, 2024
1 parent c80018e commit 9522ba0
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 5 deletions.
5 changes: 2 additions & 3 deletions .github/workflows/conformance-gateway-api.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -122,10 +122,9 @@ jobs:
CILIUM_INSTALL_DEFAULTS="${{ steps.default_vars.outputs.cilium_install_defaults }} \
--helm-set=debug.verbose=envoy \
--helm-set kubeProxyReplacement=true \
--helm-set=kubeProxyReplacement=true \
--helm-set=gatewayAPI.enabled=true \
--helm-set=l2announcements.enabled=true \
--helm-set=devices='{eth0}'"
--helm-set=l2announcements.enabled=true"
echo cilium_install_defaults=${CILIUM_INSTALL_DEFAULTS} >> $GITHUB_OUTPUT
echo skipped_tests=${SKIPPED_TESTS} >> $GITHUB_OUTPUT
Expand Down
3 changes: 1 addition & 2 deletions .github/workflows/conformance-ingress.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -146,8 +146,7 @@ jobs:
--helm-set=ingressController.loadbalancerMode=${{ matrix.loadbalancer-mode }} \
--helm-set=ingressController.default=${{ matrix.default-ingress-controller }} \
--helm-set=extraConfig.bpf-lb-acceleration=${{ matrix.bpf-lb-acceleration }} \
--helm-set=l2announcements.enabled=true \
--helm-set=devices='{eth0}'"
--helm-set=l2announcements.enabled=true"
echo cilium_install_defaults=${CILIUM_INSTALL_DEFAULTS} >> $GITHUB_OUTPUT
Expand Down

0 comments on commit 9522ba0

Please sign in to comment.