Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
all: remove unnecessary string(byteslice) when passed into fmt.*rintf…
…("%s", string(b)) fmt.*printf's "%s" verb converts values to strings in a performant way so no need to cast and unnecessarily allocate byteslice->string conversions. Noticed from own benchmarking per https://dashboard.github.orijtech.com/benchmark/3245b8e4bbbd44a597480319aaa4b9fe that avoiding this unnecessary pattern can reduce time spent and allocations by quite a big value and that showed the following improvements: ```shell * time/op (ns/op) FormatIt-8 1.2µs ± 2% 1.1µs ± 10% -11.77% (p=0.000 n=10+9) * allocs/op (MBs/op) FormatIt-8 0.71GB/s ± 2% 0.80GB/s ± 9% +13.59% (p=0.000 n=10+9) * allocs/op (B/op) FormatIt-8 2.0kB ± 0% 1.1kB ± 0% -45.62% (p=0.000 n=10+10) * allocs/op (count/op) FormatIt-8 11 ± 0% 9.0 ± 0% -18.18% (p=0.000 n=10+10) ``` Signed-off-by: Emmanuel T Odeke <emmanuel@orijtech.com>
- Loading branch information