Skip to content

Commit

Permalink
gha: Remove privilege helm option in {Ingress, Gateway}
Browse files Browse the repository at this point in the history
[ upstream commit 58366eb ]

Originally, this option is added for old minikube version, which
requires privilege permission to mount ebpf dir, however, we have
migrated to kind + metallb in Ingress and Gateway related workflows.

Signed-off-by: Tam Mach <tam.mach@cilium.io>
Signed-off-by: Donia <donia.cld@isovalent.com>
Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
  • Loading branch information
sayboras authored and giorio94 committed Sep 27, 2023
1 parent e3bbd11 commit 9e10831
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 2 deletions.
1 change: 0 additions & 1 deletion .github/workflows/conformance-gateway-api.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,6 @@ jobs:
--helm-set=operator.image.tag=${SHA} \
--helm-set=operator.image.useDigest=false \
--helm-set kubeProxyReplacement=strict \
--helm-set=securityContext.privileged=true \
--helm-set=gatewayAPI.enabled=true \
--rollback=false \
--version="
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/conformance-ingress.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,6 @@ jobs:
--helm-set=operator.image.suffix=-ci \
--helm-set=operator.image.tag=${SHA} \
--helm-set=operator.image.useDigest=false \
--helm-set=securityContext.privileged=true \
--helm-set kubeProxyReplacement=strict \
--helm-set=ingressController.enabled=true \
--helm-set=ingressController.loadbalancerMode=${{ matrix.loadbalancer-mode }} \
Expand Down

0 comments on commit 9e10831

Please sign in to comment.